Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Move versioned feature history into feature details modal #4499

Merged
merged 10 commits into from
Sep 10, 2024
Merged

feat: Move versioned feature history into feature details modal #4499

merged 10 commits into from
Sep 10, 2024

Conversation

kyle-ssg
Copy link
Member

@kyle-ssg kyle-ssg commented Aug 14, 2024 •
edited
Loading

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Moves the feature history page to within the feature modal

image

How did you test this code?

E2E tests need to be changed however no functionality has changed except removing the feature select.

@kyle-ssg kyle-ssg requested a review from a team as a code owner August 14, 2024 18:16
@kyle-ssg kyle-ssg requested review from novakzaballa and removed request for a team August 14, 2024 18:16
@vercel Vercel
Copy link

vercel bot commented Aug 14, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 21, 2024 10:34am
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 21, 2024 10:34am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Aug 21, 2024 10:34am

@github-actions github-actions bot added the front-end Issue related to the React Front End Dashboard label Aug 14, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 14, 2024 •
edited
Loading

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-4499 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-4499 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-4499 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4499 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith:pr-4499 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-frontend:pr-4499 Finished ✅ Results ✅

@github-actions github-actions bot added the feature New feature or request label Aug 14, 2024
@kyle-ssg kyle-ssg requested a review from rolodato August 14, 2024 18:17
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 14, 2024 •
edited
Loading

Uffizzi Preview deployment-55269 was deleted.

@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Aug 14, 2024
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Aug 14, 2024
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Aug 14, 2024
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Aug 14, 2024
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Aug 14, 2024
@kyle-ssg
Merge branch 'refs/heads/main' into feat/move-history
ed12206 
# Conflicts:
#	frontend/web/components/FeatureHistory.tsx
#	frontend/web/components/modals/CreateFlag.js
@kyle-ssg
UI changes
ff4d634
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Aug 21, 2024
@kyle-ssg
Copy link
Member Author

kyle-ssg commented Aug 21, 2024 •
edited
Loading

  • The contents of the History tab can expand beyond what I'm allowed to scroll to

Fixed

  • The contents of each entry's Quick Compare has too much whitespace for simple changes like turning a flag on/off

Fixed

  • The "View History" option in the Features list links to the original History page, which is now a 404

Adjusted to link to tab within modal

  • The details view for each history entry looks orphaned, like it doesn't belong to any sidebar category

Added breadcrumb to feature

@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Aug 21, 2024
novakzaballa
novakzaballa reviewed Aug 21, 2024
View reviewed changes
frontend/web/components/FeatureHistory.tsx
theme={'page'}
/>
)}
{/*{!!versionLimit && (*/}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any reason to keep this commented?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, because we're adjusting the version limit to be time based and I want to keep this here

Copy link
Member Author

@kyle-ssg kyle-ssg Aug 21, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'll be updated next week

edit: #4547

novakzaballa
novakzaballa reviewed Aug 21, 2024
View reviewed changes
Copy link
Contributor

@novakzaballa novakzaballa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good, I just left a small comment.

@kyle-ssg
Copy link
Member Author

@rolodato final review ? 🙏

rolodato
rolodato approved these changes Sep 10, 2024
View reviewed changes
Copy link
Member

@rolodato rolodato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest renaming this PR to feat: Move versioned feature history into feature details modal before merging

@kyle-ssg kyle-ssg changed the title feat: Move history feat: Move versioned feature history into feature details modal Sep 10, 2024
@kyle-ssg kyle-ssg added this pull request to the merge queue Sep 10, 2024
Merged via the queue into main with commit ae47db1 Sep 10, 2024
31 checks passed
@kyle-ssg kyle-ssg deleted the feat/move-history branch September 10, 2024 13:47
@flagsmithdev flagsmithdev mentioned this pull request Sep 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@novakzaballa novakzaballa novakzaballa left review comments

@rolodato rolodato rolodato approved these changes

Assignees
No one assigned
Labels
feature New feature or request front-end Issue related to the React Front End Dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kyle-ssg @rolodato @novakzaballa