Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add tag based permissions #4643

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

kyle-ssg
Copy link
Member

@kyle-ssg kyle-ssg commented Sep 18, 2024

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Supersedes #4250

When setting project and environment level permissions, users will now be able to enable and specify tags that the permissions apply to. Specifying tags will only apply to certain permissions (see docs)

image

image

How did you test this code?

I'm not able to until #4640 is sorted

Copy link

vercel bot commented Sep 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 18, 2024 6:47pm
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 18, 2024 6:47pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 18, 2024 6:47pm

@github-actions github-actions bot added front-end Issue related to the React Front End Dashboard docs Documentation updates labels Sep 18, 2024
Copy link
Contributor

github-actions bot commented Sep 18, 2024

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-4643 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-4643 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-4643 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-4643 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4643 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-4643 Finished ✅ Results

@kyle-ssg kyle-ssg requested review from rolodato and gagantrivedi and removed request for zachaysan September 18, 2024 18:48
@kyle-ssg kyle-ssg changed the title Add tag based permissions feat: Add tag based permissions Sep 18, 2024
Copy link
Contributor

github-actions bot commented Sep 18, 2024

Uffizzi Ephemeral Environment deployment-56425

☁️ https://app.uffizzi.com/github.com/Flagsmith/flagsmith/pull/4643

📄 View Application Logs etc.

What is Uffizzi? Learn more!

@rolodato
Copy link
Member

I don't understand how this is supposed to be used based on the docs description.

From what I understand, this functionality allows defining feature-level permissions so that only specific users can modify certain sensitive features. Happy to collaborate on these docs but I'd like to sync and understand how this functionality actually works first.

@kyle-ssg
Copy link
Member Author

I don't understand how this is supposed to be used based on the docs description.

From what I understand, this functionality allows defining feature-level permissions so that only specific users can modify certain sensitive features. Happy to collaborate on these docs but I'd like to sync and understand how this functionality actually works first.

It's quite hard to describe but it does work as updated in the docs.

If permissions are tagged, the following permissions will only be granted on features with matching tags:

  • Create feature, Update Feature, Segment Overrides, and Change Requests

If a user has admin permissions from another role or group it'll grant the user the missing permissions.

@kyle-ssg
Copy link
Member Author

kyle-ssg commented Sep 24, 2024

@gagantrivedi cc just to confirm, were the missing permissions added? This used to be just update feature and segment override

@gagantrivedi
Copy link
Member

@gagantrivedi cc just to confirm, were the missing permissions added? This used to be just update feature and segment override

No, they are not added yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation updates front-end Issue related to the React Front End Dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants