Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: combine value + segment change requests for versioned environments #4738

Merged
merged 9 commits into from
Dec 3, 2024

Conversation

kyle-ssg
Copy link
Member

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

This allows segment and environment changes to be created under 1 change requests for versioned environments.

How did you test this code?

Created change requests changing both the value and the segment overrides and individually.

@kyle-ssg kyle-ssg requested a review from a team as a code owner October 16, 2024 12:37
Copy link

vercel bot commented Oct 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 3, 2024 11:35am
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 3, 2024 11:35am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Dec 3, 2024 11:35am

@github-actions github-actions bot added front-end Issue related to the React Front End Dashboard feature New feature or request labels Oct 16, 2024
Copy link
Contributor

github-actions bot commented Oct 16, 2024

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-4738 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-4738 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-4738 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-4738 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4738 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-4738 Finished ✅ Results

Copy link
Contributor

github-actions bot commented Oct 16, 2024

Uffizzi Preview deployment-58628 was deleted.

Copy link
Contributor

@matthewelwell matthewelwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manual testing shows that this works as expected. Add one minor comment.

frontend/web/components/pages/ChangeRequestPage.js Outdated Show resolved Hide resolved
# Conflicts:
#	frontend/web/components/modals/CreateFlag.js
@github-actions github-actions bot removed the feature New feature or request label Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request front-end Issue related to the React Front End Dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants