Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add environment processing UI #4812

Merged
merged 3 commits into from
Nov 6, 2024
Merged

Conversation

kyle-ssg
Copy link
Member

@kyle-ssg kyle-ssg commented Nov 6, 2024

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Shows the following UI whilst an environment is creating

image

Adds types to environment creation

How did you test this code?

Created environments, they show the processing UI and then the features page once is_creating is false.

@kyle-ssg kyle-ssg requested a review from a team as a code owner November 6, 2024 12:03
Copy link

vercel bot commented Nov 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 6, 2024 0:07am
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 6, 2024 0:07am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Nov 6, 2024 0:07am

@github-actions github-actions bot added the front-end Issue related to the React Front End Dashboard label Nov 6, 2024
@kyle-ssg kyle-ssg linked an issue Nov 6, 2024 that may be closed by this pull request
Copy link
Contributor

github-actions bot commented Nov 6, 2024

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-4812 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api-test:pr-4812 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-4812 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4812 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-4812 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4812 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-4812 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-4812 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-4812 Finished ✅ Results

@kyle-ssg kyle-ssg changed the title Add environment processing UI feat: add environment processing UI Nov 6, 2024
Copy link
Contributor

github-actions bot commented Nov 6, 2024

Uffizzi Preview deployment-58015 was deleted.

Copy link
Contributor

@matthewelwell matthewelwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed code and tested manually. All looks good to me.

@kyle-ssg kyle-ssg added this pull request to the merge queue Nov 6, 2024
Merged via the queue into main with commit 9db91ae Nov 6, 2024
30 checks passed
@kyle-ssg kyle-ssg deleted the feat/environment-creating-ui branch November 6, 2024 14:30
matthewelwell added a commit that referenced this pull request Nov 6, 2024
Copy link

sentry-io bot commented Nov 7, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ TypeError: Cannot destructure property 'store' of 't(...)' as it is null. exports.exports(web/components/EnvironmentReady... View Issue
  • ‼️ TypeError: D is undefined children(web/components/pages/EnvironmentSettin... View Issue
  • ‼️ TypeError: Cannot read properties of null (reading 'prevent_flag_defaults') children(web/components/pages/ProjectSettingsPage) View Issue
  • ‼️ TypeError: Cannot destructure property 'store' of 't(...)' as it is null. exports.exports(web/components/EnvironmentReady... View Issue
  • ‼️ TypeError: Cannot read properties of null (reading 'prevent_flag_defaults') children(web/components/pages/ProjectSettingsPage) View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request front-end Issue related to the React Front End Dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Creating an environment can take a long time and seem unresponsive
2 participants