Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent lock when adding FFAdmin.uuid column #4832

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

matthewelwell
Copy link
Contributor

Changes

Prevents needing a lock when adding the uuid field to the user model.

How did you test this code?

Ran python manage.py sqlmigrate users 0037 to ensure that the resultant behaviour is still what we expect.

@matthewelwell matthewelwell requested a review from a team as a code owner November 12, 2024 16:41
@matthewelwell matthewelwell requested review from gagantrivedi and removed request for a team November 12, 2024 16:41
Copy link

vercel bot commented Nov 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Nov 12, 2024 4:41pm
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Nov 12, 2024 4:41pm
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Nov 12, 2024 4:41pm

@github-actions github-actions bot added api Issue related to the REST API fix labels Nov 12, 2024
Copy link
Contributor

github-actions bot commented Nov 12, 2024

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-4832 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api-test:pr-4832 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-4832 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api:pr-4832 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4832 Finished ✅ Results

Copy link
Contributor

github-actions bot commented Nov 12, 2024

Uffizzi Preview deployment-58198 was deleted.

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.33%. Comparing base (cbd60d9) to head (86d73b4).
Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4832   +/-   ##
=======================================
  Coverage   97.33%   97.33%           
=======================================
  Files        1180     1180           
  Lines       41231    41231           
=======================================
  Hits        40131    40131           
  Misses       1100     1100           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matthewelwell matthewelwell merged commit 4a310b0 into main Nov 13, 2024
34 checks passed
@matthewelwell matthewelwell deleted the fix/prevent-lock-when-adding-uuid-column branch November 13, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants