Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix prettier issues and replace prettier pre-commit hook #4867

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

matthewelwell
Copy link
Contributor

Changes

Replace the pre-commit prettier check with just a manual command because it's not possible to update the version correctly from the mirror.

How did you test this code?

Tried to commit a file with a prettier error and verified that pre-commit failed. Fixed the error and verified that commit worked.

@matthewelwell matthewelwell requested a review from a team as a code owner November 26, 2024 15:03
@matthewelwell matthewelwell requested review from gagantrivedi and removed request for a team November 26, 2024 15:03
Copy link

vercel bot commented Nov 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 26, 2024 3:03pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Nov 26, 2024 3:03pm
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Nov 26, 2024 3:03pm

@github-actions github-actions bot added docs Documentation updates and removed docs Documentation updates labels Nov 26, 2024
Copy link
Contributor

github-actions bot commented Nov 26, 2024

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-4867 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-4867 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-4867 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api:pr-4867 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-4867 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4867 Finished ✅ Results

@github-actions github-actions bot added the chore label Nov 26, 2024
Copy link
Contributor

github-actions bot commented Nov 26, 2024

Uffizzi Preview deployment-58588 was deleted.

@matthewelwell matthewelwell merged commit 39556c0 into main Nov 28, 2024
31 checks passed
@matthewelwell matthewelwell deleted the chore/docs-formatting branch November 28, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants