Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: anchor button height #4891

Merged
merged 2 commits into from
Dec 5, 2024
Merged

fix: anchor button height #4891

merged 2 commits into from
Dec 5, 2024

Conversation

kyle-ssg
Copy link
Member

@kyle-ssg kyle-ssg commented Dec 4, 2024 •
edited
Loading

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Before:
image

After:
image

How did you test this code?

Please describe.

@kyle-ssg kyle-ssg requested a review from a team as a code owner December 4, 2024 14:32
@kyle-ssg kyle-ssg requested review from tiagoapolo and removed request for a team December 4, 2024 14:32
@vercel Vercel
Copy link

vercel bot commented Dec 4, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 4, 2024 4:49pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 4, 2024 4:49pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Dec 4, 2024 4:49pm

@kyle-ssg kyle-ssg marked this pull request as draft December 4, 2024 14:32
@github-actions github-actions bot added the front-end Issue related to the React Front End Dashboard label Dec 4, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2024 •
edited
Loading

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-4891 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-4891 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-4891 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith:pr-4891 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4891 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-frontend:pr-4891 Finished ✅ Results ✅

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2024 •
edited
Loading

Uffizzi Preview deployment-58818 was deleted.

@kyle-ssg kyle-ssg marked this pull request as ready for review December 4, 2024 16:48
@kyle-ssg kyle-ssg changed the title fix anchor button height fix: anchor button height Dec 4, 2024
@matthewelwell matthewelwell merged commit 7048c4c into main Dec 5, 2024
47 of 48 checks passed
@matthewelwell matthewelwell deleted the fix/anchor-button-height branch December 5, 2024 16:02
@flagsmithdev flagsmithdev mentioned this pull request Dec 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewelwell matthewelwell matthewelwell approved these changes

@tiagoapolo tiagoapolo Awaiting requested review from tiagoapolo tiagoapolo is a code owner automatically assigned from Flagsmith/flagsmith-front-end

Assignees
No one assigned
Labels
front-end Issue related to the React Front End Dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kyle-ssg @matthewelwell