Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Relax Hubspot cookie tracking #4905

Merged
merged 6 commits into from
Dec 10, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions api/integrations/lead_tracking/hubspot/services.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,18 +12,26 @@ def register_hubspot_tracker(request: Request) -> None:
hubspot_cookie = request.data.get(HUBSPOT_COOKIE_NAME)

if not hubspot_cookie:
logger.info(f"Request did not included Hubspot data for user {request.user.id}")
return

if (
HubspotTracker.objects.filter(hubspot_cookie=hubspot_cookie)
.exclude(user=request.user)
.exists()
):
logger.info(
f"Request did not included Hubspot data for user {request.user.email}"
f"HubspotTracker could not be created for user {request.user.id}"
f" due to cookie conflict with cookie {hubspot_cookie}"
)
return

logger.info(
f"Creating HubspotTracker instance for user {request.user.email} with cookie {hubspot_cookie}"
)

HubspotTracker.objects.update_or_create(
user=request.user,
defaults={
"hubspot_cookie": hubspot_cookie,
},
)
logger.info(
f"Created HubspotTracker instance for user {request.user.id} with cookie {hubspot_cookie}"
)
34 changes: 34 additions & 0 deletions api/tests/unit/organisations/test_unit_organisations_views.py
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,40 @@ def test_non_superuser_can_create_new_organisation_by_default(
assert HubspotTracker.objects.filter(user=staff_user).exists()


def test_colliding_hubspot_cookies_are_ignored(
staff_client: APIClient,
staff_user: FFAdminUser,
admin_user: FFAdminUser,
) -> None:
# Given
org_name = "Test create org"
webhook_notification_email = "test@email.com"
url = reverse("api-v1:organisations:organisation-list")
colliding_cookie = "test_cookie_tracker"
HubspotTracker.objects.create(
user=admin_user,
hubspot_cookie=colliding_cookie,
)
data = {
"name": org_name,
"webhook_notification_email": webhook_notification_email,
HUBSPOT_COOKIE_NAME: colliding_cookie,
}

assert not HubspotTracker.objects.filter(user=staff_user).exists()

# When
response = staff_client.post(url, data=data)

# Then
assert response.status_code == status.HTTP_201_CREATED
assert (
Organisation.objects.get(name=org_name).webhook_notification_email
== webhook_notification_email
)
assert not HubspotTracker.objects.filter(user=staff_user).exists()


@override_settings(RESTRICT_ORG_CREATE_TO_SUPERUSERS=True)
def test_create_new_orgnisation_returns_403_with_non_superuser(
staff_client: APIClient,
Expand Down
Loading