Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: reusable copy to clipboard method and adds error handling #5010

Merged
merged 2 commits into from
Jan 28, 2025

Conversation

tiagoapolo
Copy link
Contributor

@tiagoapolo tiagoapolo commented Jan 16, 2025

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

  • Improves code consistency when using copy to clipboard method and removes redundant code.

How did you test this code?

  • Click on a feature and click on copy to clipboard to copy the feature name
  • Go to SDK Keys page and click on copy to clipboard to copy the SDK keys

@tiagoapolo tiagoapolo requested a review from a team as a code owner January 16, 2025 17:20
@tiagoapolo tiagoapolo requested review from kyle-ssg and removed request for a team January 16, 2025 17:20
@tiagoapolo tiagoapolo self-assigned this Jan 16, 2025
Copy link

vercel bot commented Jan 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 17, 2025 3:35pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 17, 2025 3:35pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Jan 17, 2025 3:35pm

@github-actions github-actions bot added front-end Issue related to the React Front End Dashboard chore labels Jan 16, 2025
Copy link
Contributor

github-actions bot commented Jan 16, 2025

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-5010 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-5010 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-5010 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-5010 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-5010 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-5010 Finished ✅ Results

Copy link
Contributor

github-actions bot commented Jan 16, 2025

Uffizzi Preview deployment-59990 was deleted.

Copy link
Member

@kyle-ssg kyle-ssg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff!

@tiagoapolo tiagoapolo merged commit 43108f9 into main Jan 28, 2025
31 checks passed
@tiagoapolo tiagoapolo deleted the chore/unify-copy-clipboard-method branch January 28, 2025 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore front-end Issue related to the React Front End Dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants