Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: split testing UI #5093

Open
wants to merge 20 commits into
base: main
Choose a base branch
from
Open

feat: split testing UI #5093

wants to merge 20 commits into from

Conversation

kyle-ssg
Copy link
Member

@kyle-ssg kyle-ssg commented Feb 12, 2025 •
edited
Loading

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

  • Adds a split testing results UI indicating the confidence that a multivariate feature flag is producing more conversion events

How did you test this code?

kyle-ssg and others added 8 commits September 10, 2024 16:50
@kyle-ssg
Add split testing UI
a0942ac
@matthewelwell
Add split testing to test docker build
159979f
@matthewelwell
Use current PR image for docker-compose
34bb935
@kyle-ssg
Adjust table header names
2419f54
@kyle-ssg
Merge remote-tracking branch 'origin/feat/split-testing-ui' into feat…
37bfbe5 
…/split-testing-ui
@matthewelwell
Bump split-testing version
8284594
@kyle-ssg
Merge branch 'refs/heads/main' into feat/split-testing-ui
dc76367 
# Conflicts:
#	Dockerfile
#	api/poetry.lock
#	frontend/common/types/requests.ts
#	frontend/common/types/responses.ts
#	frontend/web/components/pages/HomeAside.tsx
#	frontend/web/routes.js
@kyle-ssg
Merge remote-tracking branch 'origin/feat/split-testing-ui' into feat…
acfd279 
…/split-testing-ui

# Conflicts:
#	api/poetry.lock
@kyle-ssg kyle-ssg requested review from a team as code owners February 12, 2025 13:35
@kyle-ssg kyle-ssg requested review from tiagoapolo and matthewelwell and removed request for a team February 12, 2025 13:35
@vercel Vercel
Copy link

vercel bot commented Feb 12, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 26, 2025 11:31am
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 26, 2025 11:31am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Feb 26, 2025 11:31am

@kyle-ssg kyle-ssg marked this pull request as draft February 12, 2025 13:35
@github-actions github-actions bot added front-end Issue related to the React Front End Dashboard api Issue related to the REST API labels Feb 12, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 12, 2025 •
edited
Loading

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-frontend:pr-5093 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-api-test:pr-5093 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-5093 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-5093 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith:pr-5093 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-private-cloud:pr-5093 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-frontend:pr-5093 Finished ✅ Results ✅

@github-actions github-actions bot added the feature New feature or request label Feb 12, 2025
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Feb 12, 2025
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Feb 12, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 12, 2025 •
edited
Loading

Uffizzi Ephemeral Environment deployment-60854

☁️ https://app.uffizzi.com/github.com/Flagsmith/flagsmith/pull/5093

📄 View Application Logs etc.

What is Uffizzi? Learn more!

@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Feb 12, 2025
@matthewelwell matthewelwell marked this pull request as ready for review February 12, 2025 16:45
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Feb 12, 2025
@matthewelwell matthewelwell marked this pull request as draft February 12, 2025 16:47
@kyle-ssg
Merge branch 'refs/heads/main' into feat/split-testing-ui
20ddeae 
# Conflicts:
#	api/poetry.lock
#	frontend/common/types/requests.ts
#	frontend/common/types/responses.ts
@kyle-ssg
Merge remote-tracking branch 'origin/feat/split-testing-ui' into feat…
61b7c38 
…/split-testing-ui

# Conflicts:
#	api/poetry.lock
#	api/pyproject.toml
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Feb 26, 2025
@github-actions github-actions bot removed the feature New feature or request label Feb 26, 2025
@kyle-ssg kyle-ssg marked this pull request as ready for review February 26, 2025 11:25
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Feb 26, 2025
@flagsmith flagsmith bot added the flagsmith flag The Issue/PR has a linked feaature flag in Flagsmith label Feb 26, 2025
@flagsmith Flagsmith
Copy link

flagsmith bot commented Feb 26, 2025

Flagsmith feature linked: split_testing
Default Values:

Environment Enabled Value Last Updated (UTC)
Production ❌ Disabled 2024-02-07 17:30:35
Staging ✅ Enabled 2024-02-07 17:33:54
Demo ❌ Disabled 2024-02-07 17:30:35
Self hosted defaults ❌ Disabled 2024-02-07 17:30:35

Segment flagsmith_team values:

Environment Enabled Value Last Updated (UTC)
Self hosted defaults ✅ Enabled 2024-09-11 12:17:23
Demo2 ❌ Disabled 2025-02-14 14:07:47

@kyle-ssg
Copy link
Member Author

kyle-ssg commented Feb 26, 2025 •
edited
Loading

@matthewelwell I've removed the BE changes to this PR in order and the FE is controlled via the split_testing flag

@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiagoapolo tiagoapolo Awaiting requested review from tiagoapolo tiagoapolo is a code owner automatically assigned from Flagsmith/flagsmith-front-end

@matthewelwell matthewelwell Awaiting requested review from matthewelwell matthewelwell was automatically assigned from Flagsmith/flagsmith-back-end

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
api Issue related to the REST API feature New feature or request flagsmith flag The Issue/PR has a linked feaature flag in Flagsmith front-end Issue related to the React Front End Dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kyle-ssg @matthewelwell