Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Github Action optimizations #1263

Merged
merged 2 commits into from
Oct 22, 2020
Merged

ci: Github Action optimizations #1263

merged 2 commits into from
Oct 22, 2020

Conversation

piotradamczyk5
Copy link
Contributor

@piotradamczyk5 piotradamczyk5 commented Oct 22, 2020 •
edited
Loading

Fixes #1260

Test Plan

How do we know the code works?

All workflows work correctly.
Check the below list with information about changes.

Checklist

  • Cancel the previous build when a new event (push, pull request change) occurs
  • Remove flank-scripts-workflow, because it duplicates jobs made by generic workflows
  • Make Gradle wrapper validation as part of the job for security reasons
  • Skip whole integration tests if they do not have 2 or more approves, because they duplicate jobs

@piotradamczyk5 piotradamczyk5 self-assigned this Oct 22, 2020
@codecov-io
Copy link

Codecov Report

Merging #1263 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1263   +/-   ##
=========================================
  Coverage     79.65%   79.65%           
  Complexity      715      715           
=========================================
  Files           233      233           
  Lines          4399     4399           
  Branches        756      756           
=========================================
  Hits           3504     3504           
  Misses          496      496           
  Partials        399      399

@bootstraponline
Copy link
Contributor

this is awesome!

@bootstraponline bootstraponline changed the title ci: Github Action optimalizations ci: Github Action optimizations Oct 22, 2020
adamfilipow92
adamfilipow92 approved these changes Oct 22, 2020
View reviewed changes
Copy link
Contributor

@adamfilipow92 adamfilipow92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@piotradamczyk5 piotradamczyk5 merged commit cc86dac into master Oct 22, 2020
@piotradamczyk5 piotradamczyk5 deleted the #1260_github_action_optimalizations branch October 22, 2020 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sloox Sloox Sloox approved these changes

@adamfilipow92 adamfilipow92 adamfilipow92 approved these changes

@bootstraponline bootstraponline Awaiting requested review from bootstraponline

@zuziaka zuziaka Awaiting requested review from zuziaka

@pawelpasterz pawelpasterz Awaiting requested review from pawelpasterz

@jan-goral jan-goral Awaiting requested review from jan-goral

Assignees

@piotradamczyk5 piotradamczyk5

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cancel irrelevant builds on Github Actions
5 participants
@piotradamczyk5 @codecov-io @bootstraponline @Sloox @adamfilipow92