feat: Add Type to iOS #1284
Merged
feat: Add Type to iOS #1284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotradamczyk5
added
iOS
New Option
piotradamczyk5
requested review from
Sloox,
adamfilipow92,
pawelpasterz,
zuziaka,
bootstraponline and
jan-goral
|
Timestamp: 2020-10-29 12:47:59 |
Sloox
approved these changes
Oct 29, 2020
Sloox
approved these changes
Oct 29, 2020
test_runner/src/test/kotlin/Debug.kt
Outdated
| "run", | ||
| // "--dry", | ||
| // "--dump-shards", | ||
| "--output-style=single", | ||
| // "--full-junit-result", | ||
| // "--legacy-junit-result", | ||
| "-c=test_runner/src/test/kotlin/ftl/fixtures/test_app_cases/flank-$quantity-$type-$extra.yml", | ||
| "-c=/Users/piotr/Projekty/gogo/flank/test_runner/src/test/kotlin/ftl/fixtures/simple-ios-flank.yml", |
There was a problem hiding this comment.
😃 sorry stupid mistake :D
|
Buildscan url for ubuntu-workflow run 335504439 |
Codecov Report
@@ Coverage Diff @@
## master #1284 +/- ##
============================================
+ Coverage 79.66% 79.68% +0.02%
Complexity 724 724
============================================
Files 235 235
Lines 4489 4494 +5
Branches 771 772 +1
============================================
+ Hits 3576 3581 +5
Misses 514 514
Partials 399 399 |
jan-goral
reviewed
Oct 29, 2020
bootstraponline
force-pushed
the
#1194_ios_add_type
branch
from
9fd389e to
726c970
Compare
|
Buildscan url for ubuntu-workflow run 335689673 |
bootstraponline
force-pushed
the
#1194_ios_add_type
branch
from
726c970 to
b33ba67
Compare
It was done for Android, did it for iOS |
jan-goral
approved these changes
Oct 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1194
Test Plan
Flank properly read type passed to
gcloudconfiguration.yamlblock or using CLI option--type.Later on it will be used to run gameloop in #1277
Checklist