fix: Generation of release notes #1366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotradamczyk5
requested review from
bootstraponline,
Sloox,
zuziaka,
pawelpasterz,
jan-goral and
adamfilipow92
pawelpasterz
approved these changes
Dec 1, 2020
Sloox
approved these changes
Dec 1, 2020
| @@ -201,4 +201,4 @@ fun <T> withTempFile(block: File.() -> T): T { | |||
| return block(tempFile).also { tempFile.delete() } | |||
| } | |||
|
|
|||
| tasks["detekt"].dependsOn(tasks["checkIfVersionUpdated"]) | |||
| // TODO temporary disabled tasks["check"].dependsOn(tasks["checkIfVersionUpdated"]) | |||
There was a problem hiding this comment.
Make a ticket for this so its not forgotten about?
There was a problem hiding this comment.
yeah I will do it just after merging it
adamfilipow92
approved these changes
Dec 1, 2020
Codecov Report
@@ Coverage Diff @@
## master #1366 +/- ##
============================================
- Coverage 77.81% 77.79% -0.03%
Complexity 705 705
============================================
Files 244 244
Lines 4693 4693
Branches 901 901
============================================
- Hits 3652 3651 -1
Misses 550 550
- Partials 491 492 +1 |
|
Timestamp: 2020-12-01 14:15:06 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue was caused by bad content type used in api
Test Plan
flank-scripts/bash/flankScripts ci generateReleaseNotes --token=$GITHUB_TOKENrelease_notes.md