Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: trigger integration tests from pr comment #1409

Merged
merged 6 commits into from
Dec 17, 2020

Conversation

piotradamczyk5
Copy link
Contributor

@piotradamczyk5 piotradamczyk5 commented Dec 17, 2020

Fixes #1349

Test Plan

How do we know the code works?

Current flows:

  1. Schedule and manual trigger
  • should cancel other builds in progress
  • should run full integration tests on master branch
  • should process results using flank scripts
  1. Comment trigger
  • should get pr number
  • should post an issue comment
  • should run full integration tests on PR branch
  • should update comment based on test results

Integration tests run:

  1. Integration tests build flank when the environmental variable CI is set to true
  2. Integration tests do not build flank locally( when variable CI is set to false)

Comment trigger

  1. Integration tests full suite is triggered by posting comment @flank-it
  2. When Github action started 👀 are displayed under user comment
    image
  3. When Integration tests started comment is posted with a link to the integration test and timestamp (and a 🚀 )
    image
  4. After tests finished, comment from the previous step is replaced to result description and reaction(👍 :success, 👎 :failure)
    image

Fork playground

  • integration tests failed, because of missing service account

Checklist

  • Add comment trigger
  • Show status on PR
  • Integration tests should depend on build for CI builds

@github-actions
Copy link
Contributor

github-actions bot commented Dec 17, 2020

Timestamp: 2020-12-17 15:59:27
Buildscan url for ubuntu-workflow run 428469668
https://gradle.com/s/kyuhgran3wvvm

@codecov-io
Copy link

Codecov Report

Merging #1409 (58e522e) into master (73c9084) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1409      +/-   ##
============================================
+ Coverage     77.32%   77.36%   +0.04%     
- Complexity      719      720       +1     
============================================
  Files           250      250              
  Lines          4834     4834              
  Branches        922      922              
============================================
+ Hits           3738     3740       +2     
+ Misses          596      595       -1     
+ Partials        500      499       -1     

Copy link
Contributor

@Sloox Sloox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think its fine.

@Sloox
Copy link
Contributor

Sloox commented Dec 17, 2020

@flank-it

@piotradamczyk5
Copy link
Contributor Author

@flank-it

Not this time @Sloox :D must be merged first
it works on Fork playground

Co-authored-by: bootstraponline <code@bootstraponline.com>
@piotradamczyk5 piotradamczyk5 marked this pull request as ready for review December 17, 2020 14:51
Copy link
Contributor

@adamfilipow92 adamfilipow92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@piotradamczyk5 piotradamczyk5 merged commit 2b84392 into master Dec 17, 2020
@piotradamczyk5 piotradamczyk5 deleted the #1349_trigger_pr_from_comment branch December 17, 2020 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[IT] Comment trigger for full suite integration tests
5 participants