Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: 1411 implement version #1412

Merged
merged 2 commits into from
Dec 18, 2020
Merged

ci: 1411 implement version #1412

merged 2 commits into from
Dec 18, 2020

Conversation

pawelpasterz
Copy link
Contributor

@pawelpasterz pawelpasterz commented Dec 18, 2020

Fixes #1411

Implement Version class (and related logic) to handle dependencies versioning

Test Plan

How do we know the code works?

  1. run
     git checkout master &&\
       ./gradlew clean assemble &&\
       ./gradlew dependencyUpdates -DoutputFormatter=json -DoutputDir=. &&\
       java -jar ./flank-scripts/build/libs/flank-scripts.jar  dependencies update &&\
       git diff >> dep_master
    
  2. run
    git checkout . &&\
      git checkout 1411-implement-version &&\
      ./gradlew clean assemble &&\
      ./gradlew dependencyUpdates -DoutputFormatter=json -DoutputDir=. &&\
      java -jar ./flank-scripts/build/libs/flank-scripts.jar  dependencies update &&\
      git diff >> dep_version
    
  3. compare dep files
    diff dep_master dep_version
    
  4. there should be no differences (nothing is printed to the console, exit code = 0)

Checklist

  • Unit tested

@pawelpasterz pawelpasterz marked this pull request as draft December 18, 2020 08:24
@pawelpasterz pawelpasterz force-pushed the 1411-implement-version branch from 1b96d4c to a1064d2 Compare December 18, 2020 08:26
@codecov-io
Copy link

Codecov Report

Merging #1412 (a1064d2) into master (2b84392) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1412      +/-   ##
============================================
- Coverage     77.34%   77.32%   -0.03%     
  Complexity      719      719              
============================================
  Files           250      250              
  Lines          4834     4834              
  Branches        922      922              
============================================
- Hits           3739     3738       -1     
  Misses          596      596              
- Partials        499      500       +1     

@github-actions
Copy link
Contributor

Timestamp: 2020-12-18 08:31:47
Buildscan url for ubuntu-workflow run 430024991
https://gradle.com/s/uu4mjicfnv2f2

@pawelpasterz pawelpasterz self-assigned this Dec 18, 2020
@pawelpasterz pawelpasterz marked this pull request as ready for review December 18, 2020 09:13
@mergify mergify bot merged commit 5bb6870 into master Dec 18, 2020
@mergify mergify bot deleted the 1411-implement-version branch December 18, 2020 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use Version instead of String in update dependencies logic
4 participants