-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Default project Id - use GOOGLE_APPLICATION_CREDENTIALS first, then GOOGLE_CLOUD_PROJECT #1421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawelpasterz
requested review from
Sloox,
zuziaka,
jan-goral,
adamfilipow92 and
piotradamczyk5
December 23, 2020 04:58
Timestamp: 2020-12-23 13:07:33 |
pawelpasterz
force-pushed
the
1407-use-provided-credentials-first
branch
from
December 23, 2020 05:38
ecdea65
to
579162c
Compare
@flank-it |
Integration tests succeed, you could see results here |
Sloox
approved these changes
Dec 23, 2020
pawelpasterz
changed the title
feature: Default project Id - use GOOGLE_APPLICATION_CREDENTIALS first, then GOOGLE_CLOUD_PROJECT
feat: Default project Id - use GOOGLE_APPLICATION_CREDENTIALS first, then GOOGLE_CLOUD_PROJECT
Dec 23, 2020
pawelpasterz
force-pushed
the
1407-use-provided-credentials-first
branch
from
December 23, 2020 12:21
579162c
to
c35357a
Compare
pawelpasterz
force-pushed
the
1407-use-provided-credentials-first
branch
from
December 23, 2020 13:03
c35357a
to
4f37042
Compare
piotradamczyk5
approved these changes
Dec 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1407
Flank will now use
GOOGLE_APPLICATION_CREDENTIALS
env first, to parse and get project id. (previously the first one wasGOOGLE_CLOUD_PROJECT
Test Plan
java -jar ./test_runner/build/libs/flank.jar
echo '{"project_id":"any funny project id here"}' >> test.json
export GOOGLE_APPLICATION_CREDENTIALS="$(pwd)/test.json"
export GOOGLE_CLOUD_PROJECT="another project id"
ddd
project id during local tests and it turned out there is such project, I received 403 instead 😄 ) with a messageFlank was unable to find project [id from step 4.]
Flank encountered a 403 error when running on project [id from 2.] (from [path to file from 2.])
export GOOGLE_APPLICATION_CREDENTIALS=
export GOOGLE_CLOUD_PROJECT=
Checklist