Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Added CLA assistant #1451

Merged
merged 5 commits into from
Jan 5, 2021
Merged

ci: Added CLA assistant #1451

merged 5 commits into from
Jan 5, 2021

Conversation

piotradamczyk5
Copy link
Contributor

@piotradamczyk5 piotradamczyk5 commented Jan 4, 2021

Fixes #638

Added Github action which requires the contributor to sign CLA agreement by making a comment I have read the CLA Document and I hereby sign the CLA
Flank organization members do not need to sign contribution, as well as bots

Test Plan

How do we know the code works?

  1. User create Pull request
  2. CLA assistant make a comment that User needs to sign CLA

Zrzut ekranu 2021-01-4 o 17 12 50

  1. User sign CLA by posting a comment I have read the CLA Document and I hereby sign the CLA

Zrzut ekranu 2021-01-4 o 17 13 11

  1. User signature is stored in cla/v1/signatures.json on cla_signatures branch
  2. CLA assistant make a comment that all committers signed CLA

Zrzut ekranu 2021-01-4 o 17 13 41

The real testing scenario will be done in the next PR to make sure that everything works correctly!!!

Checklist

  • Documented

@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2021

Timestamp: 2021-01-05 10:48:32
Buildscan url for ubuntu-workflow run 463169832
https://gradle.com/s/rcvw6ingfsd5c

path-to-signatures: 'cla/v1/signatures.json'
path-to-document: 'https://github.com/Flank/flank/blob/cla_signatures/cla.md'
branch: 'cla_signatures'
allowlist: bootstraponline,jan-gogo,pawelpasterz,adamfilipow92,piotradamczyk5,Sloox,axelzuziak-gogo,bot*
Copy link
Contributor Author

@piotradamczyk5 piotradamczyk5 Jan 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will add piotradamczyk5 in the next PR to make sure that everything works correctly

@piotradamczyk5 piotradamczyk5 enabled auto-merge (squash) January 4, 2021 17:06
@bootstraponline
Copy link
Contributor

Flank organization members do not need to sign contribution, as well as bots

we'd want flank org members to sign the contribution (only once per github account)

bots can be excluded.

@piotradamczyk5 piotradamczyk5 merged commit 6eba8b7 into master Jan 5, 2021
@piotradamczyk5 piotradamczyk5 deleted the #638-restore-cla-bot branch January 5, 2021 10:48
@zuziaka zuziaka added this to the Sprint -1 milestone Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restore CLA bot
4 participants