ci: Added Windows workflow #1534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
Timestamp: 2021-01-27 08:05:41 |
zuziaka
reviewed
Jan 25, 2021
zuziaka
approved these changes
Jan 26, 2021
Sloox
suggested changes
Jan 26, 2021
Sloox
reviewed
Jan 26, 2021
piotradamczyk5
force-pushed
the
#1528_added_windows_workflow
branch
5 times, most recently
from
7f693d4 to
f540ee6
Compare
piotradamczyk5
force-pushed
the
#1528_added_windows_workflow
branch
from
f540ee6 to
bd0808b
Compare
pawelpasterz
previously requested changes
Jan 27, 2021
piotradamczyk5
commented
Jan 27, 2021
piotradamczyk5
commented
Jan 27, 2021
Sloox
approved these changes
Jan 27, 2021
| @@ -13,6 +13,10 @@ val userHome: String by lazy { | |||
| if (isWindows) System.getenv("HOMEPATH") else System.getProperty("user.home") | |||
| } | |||
|
|
|||
| val appDataDirectory: String by lazy { | |||
| if (isWindows) System.getenv("APPDATA") else System.getProperty("user.home") | |||
There was a problem hiding this comment.
I had a feeling something related to HOMEPATH was going to be the issue. I assume that HOMEPATH you dont have write permissions on the VM'S right?
There was a problem hiding this comment.
exactly. User directory is for users 🎉 Just one working day to figure this out
There was a problem hiding this comment.
and basically this is good practice on Windows to keep app data into app data folder instead of user one
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1528
Test Plan
Windows workflow runs and passes
Checklist