-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for emulator devices #1711
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
@flank-it |
Integration tests succeed for all OSes ✅ |
Timestamp: 2021-03-17 22:00:59 |
How will this work with the existing checks for max shards? They check specifically physical and virtual devices - as best I know there are not limits for these new emulators - so we should ensure that they don't fall into a default bucket of some sort in the validation logic. |
We will introduce skipping validation option in a future PR. AFAIK emulators are considered as virtual devices so you can use up to 500 shards. Just wanted to keep PR scope related to one topic :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
10k lines made me cry at first
In the scope of #1710
PR adds support for
EMULATOR
devicesTest Plan
./gradlew flankFullRun
flank-open-source
projectflank firebase test android models list
EMULATOR
Checklist