Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for emulator devices #1711

Merged
merged 2 commits into from
Mar 18, 2021
Merged

Conversation

pawelpasterz
Copy link
Contributor

@pawelpasterz pawelpasterz commented Mar 17, 2021

In the scope of #1710

PR adds support for EMULATOR devices

Test Plan

How do we know the code works?

  1. build flank locally with ./gradlew flankFullRun
  2. ensure you are logged to flank-open-source project
  3. run flank firebase test android models list
  4. you should see new devices of type EMULATOR
  5. run a simple test with
      device:
         - model: NexusLowResEmulator
           version: 28
    
  6. tests should finish normally

Checklist

  • Unit tested

Sorry, something went wrong.

@pawelpasterz pawelpasterz self-assigned this Mar 17, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Mar 17, 2021

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@pawelpasterz
Copy link
Contributor Author

@flank-it

@pawelpasterz pawelpasterz marked this pull request as ready for review March 17, 2021 21:59
@github-actions
Copy link
Contributor

github-actions bot commented Mar 17, 2021

Integration tests succeed for all OSes ✅
Windows Build scan:
MacOS Build scan: https://gradle.com/s/5wq5lhzpu4wiu
Linux Build scan: https://gradle.com/s/d2xjieezj7sty
Workflow run https://github.com/Flank/flank/actions/runs/662574356

@github-actions
Copy link
Contributor

Timestamp: 2021-03-17 22:00:59
Buildscan url for ubuntu-workflow run 662568814

@inktomi
Copy link

inktomi commented Mar 17, 2021

How will this work with the existing checks for max shards? They check specifically physical and virtual devices - as best I know there are not limits for these new emulators - so we should ensure that they don't fall into a default bucket of some sort in the validation logic.

@pawelpasterz
Copy link
Contributor Author

How will this work with the existing checks for max shards? They check specifically physical and virtual devices - as best I know there are not limits for these new emulators - so we should ensure that they don't fall into a default bucket of some sort in the validation logic.

We will introduce skipping validation option in a future PR. AFAIK emulators are considered as virtual devices so you can use up to 500 shards. Just wanted to keep PR scope related to one topic :)

Copy link
Contributor

@Sloox Sloox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

10k lines made me cry at first

@piotradamczyk5 piotradamczyk5 self-requested a review March 18, 2021 12:16
@mergify mergify bot merged commit f32ae8b into master Mar 18, 2021
@mergify mergify bot deleted the add-support-for-emulators branch March 18, 2021 12:17
@github-actions github-actions bot locked and limited conversation to collaborators Mar 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants