Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Update DumpShardsIT #1790

Merged
merged 1 commit into from
Apr 9, 2021
Merged

test: Update DumpShardsIT #1790

merged 1 commit into from
Apr 9, 2021

Conversation

pawelpasterz
Copy link
Contributor

Updates DumpShardsIT

@github-actions
Copy link
Contributor

github-actions bot commented Apr 9, 2021 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@pawelpasterz
Copy link
Contributor Author

@flank-it

@mergify
Copy link

mergify bot commented Apr 9, 2021

Title does not follow the guidelines of Conventional Commits.
Please adjust title before merge and use one of following prefix:

  • build - Changes that affect the build system or external dependencies (dependencies update)
  • ci - Changes to our CI configuration files and scripts (basically directory .github/workflows)
  • docs - Documentation only changes
  • feat - A new feature
  • fix - A bug fix
  • chore - Changes which does not touch the code (ex. manual update of release notes). It will not generate release notes changes
  • refactor - A code change that contains refactor
  • style - Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test - Adding missing tests or correcting existing tests and also changes for our test app
  • perf - A code change that improves performance (I do not think we will use it)

@github-actions
Copy link
Contributor

github-actions bot commented Apr 9, 2021 •
edited
Loading

Integration tests succeed for all OSes ✅
Windows Build scan:
MacOS Build scan: https://gradle.com/s/xlyh5eqwoolhq
Linux Build scan: https://gradle.com/s/diifvpl3iqlci
Workflow run https://github.com/Flank/flank/actions/runs/732613493

@github-actions
Copy link
Contributor

github-actions bot commented Apr 9, 2021

Timestamp: 2021-04-09 09:52:50
Buildscan url for ubuntu-workflow run 732612641

@pawelpasterz pawelpasterz changed the title tests: Update DumpShardsIT test: Update DumpShardsIT Apr 9, 2021
@pawelpasterz pawelpasterz enabled auto-merge (squash) April 9, 2021 10:42
Sloox
Sloox approved these changes Apr 9, 2021
View reviewed changes
Copy link
Contributor

@Sloox Sloox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What a strange error. Can you explain how you came to figure this one out?

@pawelpasterz
Copy link
Contributor Author

What a strange error. Can you explain how you came to figure this one out?

Recently there were changes in iOS dump shard structure. I thought it could be related.

@piotradamczyk5 piotradamczyk5 self-requested a review April 9, 2021 11:06
@pawelpasterz pawelpasterz merged commit cc63b0f into master Apr 9, 2021
@pawelpasterz pawelpasterz deleted the fix-IT branch April 9, 2021 11:06
@github-actions github-actions bot locked and limited conversation to collaborators Apr 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Sloox Sloox Sloox approved these changes

@piotradamczyk5 piotradamczyk5 piotradamczyk5 approved these changes

Assignees

@pawelpasterz pawelpasterz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pawelpasterz @Sloox @piotradamczyk5