refactor: Refactor data scratch-ipblocks

[piotradamczyk5]

Fixes #1746

Test Plan

How do we know the code works?

• Code is refactored according to the description in Data scratch - ip blocks #1746
• command flank ip-blocks list runs without any problems

Checklist

• Unit tested

[github-actions]

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

[github-actions]

Timestamp: 2021-04-19 15:56:21
Buildscan url for ubuntu-workflow run 764141388
https://gradle.com/s/emqdhmxeevrb6

[jan-goral]

The files:

• IpBlocksToTable.kt
• ListIPBlocks.kt TestEnvironmentInfo.kt

are not a part of the adapters layer because they don't have any references to google API libs additionally they are widely used in the domain layer. According to the diagram below, the code from adapters cannot be used directly in the domain layer.

Please move back those two files to the ftl.environment and leave them for further domain refactor.

[jan-goral]

@piotradamczyk5 Sorry for the mistake, I have copy-pasted the wrong file name, should be TestEnvironmentInfo.kt instead of ListIPBlocks.kt

[piotradamczyk5]

The files:

• IpBlocksToTable.kt
• ListIPBlocks.kt TestEnvironmentInfo.kt

are not a part of the adapters layer because they don't have any references to google API libs additionally they are widely used in the domain layer. According to the diagram below, the code from adapters cannot be used directly in the domain layer.

Please move back those two files to the ftl.environment and leave them for further domain refactor.

For me data and adapter layers are badly named:
adapter layer is data while data is adapter

[jan-goral]

@piotradamczyk5 I do not agree. The adapter is an implementation that is adapting the library code or client implementation to the data structures and interfaces declared in the data layer.

[piotradamczyk5]

@piotradamczyk5 I do not agree. The adapter is an implementation that is adapting the library code or client implementation to the data structures and interfaces declared in the data layer.

Discussed on slack with @jan-gogo .
The new package structure will be
presentation > domain > api > adapter > client

where
api is old data
old adapter is adapter + client
new adapter prepares and map data
client return data/behaviour from external API (wraps library or library itself)