Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Refactor data scratch-softwarecatalog #1823

Merged
merged 6 commits into from
Apr 22, 2021
Merged

refactor: Refactor data scratch-softwarecatalog #1823

merged 6 commits into from
Apr 22, 2021

Conversation

Sloox
Copy link
Contributor

@Sloox Sloox commented Apr 20, 2021 •
edited
Loading

Fixes #1751

Test Plan

How do we know the code works?
Code is refactored according to the description in #1751
Tests work as intended.

Checklist

  • Unit tested

@Sloox Sloox self-assigned this Apr 20, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Apr 20, 2021 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@Sloox Sloox enabled auto-merge (squash) April 20, 2021 14:46
@Sloox Sloox changed the title refactor: Refactor data SoftwareCatalog refactor: Refactor data scratch-softwarecatalog Apr 20, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Apr 20, 2021 •
edited
Loading

Timestamp: 2021-04-22 14:50:10
Buildscan url for ubuntu-workflow run 774596795
https://gradle.com/s/rh2m7nvvhual4

@jan-goral
Copy link
Contributor

@Sloox
Check this example:
https://github.com/Flank/flank/pull/1819/files#diff-9dab19db89ea08ff978778342185b8042a604f936ed9e649407972850aa6ccf0R12
this is properly solved logging at this stage of refactoring.

@Sloox
Copy link
Contributor Author

Sloox commented Apr 22, 2021

@jan-gogo Changes applied.

@Sloox Sloox requested a review from jan-goral April 22, 2021 07:14
@Sloox Sloox requested a review from adamfilipow92 April 22, 2021 14:17
adamfilipow92
adamfilipow92 approved these changes Apr 22, 2021
View reviewed changes
Copy link
Contributor

@adamfilipow92 adamfilipow92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Sloox Sloox disabled auto-merge April 22, 2021 14:43
@Sloox Sloox dismissed jan-goral’s stale review April 22, 2021 14:44

Changes addressed.

@Sloox Sloox enabled auto-merge (squash) April 22, 2021 14:44
@Sloox Sloox merged commit 6b67c07 into master Apr 22, 2021
@Sloox Sloox deleted the #1751-new-software-catalog branch April 22, 2021 14:55
@github-actions github-actions bot locked and limited conversation to collaborators Apr 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pawelpasterz pawelpasterz pawelpasterz approved these changes

@adamfilipow92 adamfilipow92 adamfilipow92 approved these changes

@bootstraponline bootstraponline Awaiting requested review from bootstraponline

@zuziaka zuziaka Awaiting requested review from zuziaka

@piotradamczyk5 piotradamczyk5 Awaiting requested review from piotradamczyk5

@jan-goral jan-goral Awaiting requested review from jan-goral

Assignees

@Sloox Sloox

Labels
Refactor Tiger 🐯
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Data scratch - software catalog
4 participants
@Sloox @jan-goral @pawelpasterz @adamfilipow92