Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: data scratch file references #1841

Merged
merged 7 commits into from
Apr 29, 2021
Merged

refactor: data scratch file references #1841

merged 7 commits into from
Apr 29, 2021

Conversation

Sloox
Copy link
Contributor

@Sloox Sloox commented Apr 24, 2021 •
edited
Loading

Fixes #1759

Test Plan

How do we know the code works?

Checklist

  • Unit tested

@Sloox Sloox self-assigned this Apr 24, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Apr 24, 2021 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@github-actions
Copy link
Contributor

github-actions bot commented Apr 24, 2021 •
edited
Loading

Timestamp: 2021-04-29 07:43:28
Buildscan url for ubuntu-workflow run 795259455
https://gradle.com/s/cxiwxpxpmtlv2

@bootstraponline bootstraponline force-pushed the #1759-file-references branch 2 times, most recently from 16848ef to d3a5039 Compare April 26, 2021 06:52
@Sloox Sloox requested a review from piotradamczyk5 April 26, 2021 13:55
jan-goral
jan-goral suggested changes Apr 26, 2021
View reviewed changes
Copy link
Contributor

@jan-goral jan-goral left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The domain code cannot have direct references to the adapters.

Check out the diagram,

architecture diagram

There is no direct reference between domain and adapter. The same about the client which is not included in the diagram but is referenced only by adapter.

@bootstraponline bootstraponline force-pushed the #1759-file-references branch 4 times, most recently from 8e591a1 to 258d64c Compare April 27, 2021 14:12
@Sloox Sloox requested a review from jan-goral April 28, 2021 11:31
@Flank Flank deleted a comment from github-actions bot Apr 28, 2021
@Sloox
Copy link
Contributor Author

Sloox commented Apr 28, 2021

@flank-it

@github-actions
Copy link
Contributor

github-actions bot commented Apr 28, 2021 •
edited
Loading

Integration tests succeed for all OSes ✅
Windows Build scan:
MacOS Build scan: https://gradle.com/s/we65pyols3ymi
Linux Build scan: https://gradle.com/s/iujdctbz7w4cm
Workflow run https://github.com/Flank/flank/actions/runs/792463398

@bootstraponline bootstraponline force-pushed the #1759-file-references branch 2 times, most recently from a62b381 to 4e41bb8 Compare April 28, 2021 16:03
adamfilipow92
adamfilipow92 approved these changes Apr 29, 2021
View reviewed changes
Copy link
Contributor

@adamfilipow92 adamfilipow92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Sloox Sloox enabled auto-merge (squash) April 29, 2021 14:45
@Sloox Sloox disabled auto-merge April 29, 2021 14:46
@Sloox Sloox merged commit c5122e8 into master Apr 29, 2021
@Sloox Sloox deleted the #1759-file-references branch April 29, 2021 14:50
@github-actions github-actions bot locked and limited conversation to collaborators Apr 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pawelpasterz pawelpasterz pawelpasterz approved these changes

@adamfilipow92 adamfilipow92 adamfilipow92 approved these changes

@bootstraponline bootstraponline Awaiting requested review from bootstraponline

@zuziaka zuziaka Awaiting requested review from zuziaka

@piotradamczyk5 piotradamczyk5 Awaiting requested review from piotradamczyk5

@jan-goral jan-goral Awaiting requested review from jan-goral

Assignees

@Sloox Sloox

Labels
Refactor Tiger 🐯
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Data scratch - file reference
5 participants
@Sloox @pawelpasterz @jan-goral @adamfilipow92 @piotradamczyk5