Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: iOS List locales #1914

Merged
merged 1 commit into from
May 11, 2021
Merged

refactor: iOS List locales #1914

merged 1 commit into from
May 11, 2021

Conversation

Sloox
Copy link
Contributor

@Sloox Sloox commented May 11, 2021

Fixes #1859

Test Plan

How do we know the code works?
Works as intended and follows outline as set out in #1859

Checklist

  • Unit tested

Sorry, something went wrong.

@github-actions
Copy link
Contributor

github-actions bot commented May 11, 2021

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@github-actions
Copy link
Contributor

github-actions bot commented May 11, 2021

Timestamp: 2021-05-11 17:35:27
Buildscan url for ubuntu-workflow run 832571624
https://gradle.com/s/opolpuoojdrum

@mergify
Copy link

mergify bot commented May 11, 2021

Title does not follow the guidelines of Conventional Commits.
Please adjust title before merge and use one of following prefix:

  • build - Changes that affect the build system or external dependencies (dependencies update)
  • ci - Changes to our CI configuration files and scripts (basically directory .github/workflows)
  • docs - Documentation only changes
  • feat - A new feature
  • fix - A bug fix
  • chore - Changes which does not touch the code (ex. manual update of release notes). It will not generate release notes changes
  • refactor - A code change that contains refactor
  • style - Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test - Adding missing tests or correcting existing tests and also changes for our test app
  • perf - A code change that improves performance (I do not think we will use it)

@Sloox Sloox changed the title refactor : iOS List locales refactor: iOS List locales May 11, 2021

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@bootstraponline bootstraponline force-pushed the 1859-list-ios-locales branch from dcbf010 to ebaba1a Compare May 11, 2021 17:29
@mergify mergify bot merged commit 673fbdb into master May 11, 2021
@mergify mergify bot deleted the 1859-list-ios-locales branch May 11, 2021 17:45
@github-actions github-actions bot locked and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Structural output - ListIosLocales
3 participants