refactor: Structural output list network profiles #1915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotradamczyk5
requested review from
Sloox,
zuziaka,
pawelpasterz,
jan-goral and
adamfilipow92
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
Timestamp: 2021-05-12 17:30:04 |
bootstraponline
force-pushed
the
1872_refactor_structural_output_network_profiles
branch
from
f46abc8 to
1093fbd
Compare
adamfilipow92
approved these changes
May 11, 2021
There was a problem hiding this comment.
- Code looks good
- Output works like before
fetching available network profiles...
┌────────────┬──────┬────────┬────────────┬───────────────────┬───────────┬───────┐
│ PROFILE_ID │ RULE │ DELAY │ LOSS_RATIO │ DUPLICATION_RATIO │ BANDWIDTH │ BURST │
├────────────┼──────┼────────┼────────────┼───────────────────┼───────────┼───────┤
│ │ up │ 0.040s │ 0.001 │ │ 16000.0 │ │
│ LTE │ down │ 0.040s │ 0.001 │ │ 16000.0 │ │
├────────────┼──────┼────────┼────────────┼───────────────────┼───────────┼───────┤
│ │ up │ 0.060s │ 0.0015 │ │ 4000.0 │ │
│ LTE-poor │ down │ 0.060s │ 0.0015 │ │ 4000.0 │ │
├────────────┼──────┼────────┼────────────┼───────────────────┼───────────┼───────┤
│ │ up │ 0.060s │ 0.001 │ │ 2000.0 │ │
│ HSPA │ down │ 0.060s │ 0.001 │ │ 4000.0 │ │
├────────────┼──────┼────────┼────────────┼───────────────────┼───────────┼───────┤
│ │ up │ 0.100s │ 0.0015 │ │ 500.0 │ │
│ HSPA-poor │ down │ 0.100s │ 0.0015 │ │ 1000.0 │ │
├────────────┼──────┼────────┼────────────┼───────────────────┼───────────┼───────┤
│ │ up │ 0.060s │ 0.02 │ │ 2000.0 │ │
│ UMTS │ down │ 0.060s │ 0.02 │ │ 2000.0 │ │
├────────────┼──────┼────────┼────────────┼───────────────────┼───────────┼───────┤
│ │ up │ 0.090s │ 0.04 │ │ 384.0 │ │
│ UMTS-poor │ down │ 0.090s │ 0.04 │ │ 384.0 │ │
├────────────┼──────┼────────┼────────────┼───────────────────┼───────────┼───────┤
│ │ up │ 0.150s │ 0.04 │ │ 384.0 │ │
│ EDGE │ down │ 0.150s │ 0.04 │ │ 384.0 │ │
├────────────┼──────┼────────┼────────────┼───────────────────┼───────────┼───────┤
│ │ up │ 0.200s │ 0.08 │ │ 96.0 │ │
│ EDGE-poor │ down │ 0.200s │ 0.08 │ │ 96.0 │ │
├────────────┼──────┼────────┼────────────┼───────────────────┼───────────┼───────┤
│ │ up │ 0.300s │ 0.08 │ │ 172.0 │ │
│ GPRS │ down │ 0.300s │ 0.08 │ │ 172.0 │ │
├────────────┼──────┼────────┼────────────┼───────────────────┼───────────┼───────┤
│ │ up │ 0.500s │ 0.1 │ │ 48.0 │ │
│ GPRS-poor │ down │ 0.500s │ 0.1 │ │ 48.0 │ │
├────────────┼──────┼────────┼────────────┼───────────────────┼───────────┼───────┤
│ │ up │ 0.500s │ 0.08 │ │ 9.6 │ │
│ GSM │ down │ 0.500s │ 0.08 │ │ 9.6 │ │
├────────────┼──────┼────────┼────────────┼───────────────────┼───────────┼───────┤
│ │ up │ 0.600s │ 0.1 │ │ 2.4 │ │
│ GSM-poor │ down │ 0.600s │ 0.1 │ │ 2.4 │ │
└────────────┴──────┴────────┴────────────┴───────────────────┴───────────┴───────┘
Total run duration: 0m 2s
1093fbd to
017e7c9
Compare
|
|
||
| @Suppress("UNCHECKED_CAST") | ||
| when { | ||
| (this as? List<NetworkProfile>) != null -> this.toCliTable() |
There was a problem hiding this comment.
Just wondering, maybe we could introduce a wrapper for the list? We could avoid casting and annotation.
True -- it touches more places in code.
Let me know what do you think
There was a problem hiding this comment.
yeah we could do it, I will add it to this PR and adjust other places
There was a problem hiding this comment.
@pawelpasterz fixed
piotradamczyk5
force-pushed
the
1872_refactor_structural_output_network_profiles
branch
from
017e7c9 to
815621a
Compare
piotradamczyk5
force-pushed
the
1872_refactor_structural_output_network_profiles
branch
from
815621a to
942c9a9
Compare
pawelpasterz
approved these changes
May 12, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1864
Test Plan
flank firebase test network-profiles listworks like beforeChecklist