Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Ubuntu updates #1942

Merged
merged 2 commits into from
May 18, 2021
Merged

ci: Ubuntu updates #1942

merged 2 commits into from
May 18, 2021

Conversation

Sloox
Copy link
Contributor

@Sloox Sloox commented May 18, 2021

Fixes #1928

Test Plan

How do we know the code works?
Revert to latest, ubuntu-latest and include fixes.

Checklist

  • Integration tests updated

@Sloox Sloox self-assigned this May 18, 2021
@github-actions
Copy link
Contributor

github-actions bot commented May 18, 2021

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@github-actions github-actions bot added the Bug label May 18, 2021
@github-actions
Copy link
Contributor

github-actions bot commented May 18, 2021

Timestamp: 2021-05-18 13:34:26
Buildscan url for ubuntu-workflow run 853468192
https://gradle.com/s/55m3lsuhzfftw

@Sloox
Copy link
Contributor Author

Sloox commented May 18, 2021

@flank-it

@github-actions
Copy link
Contributor

github-actions bot commented May 18, 2021

Integration tests succeed for all OSes ✅
Windows Build scan:
MacOS Build scan: https://gradle.com/s/do5xqpewtiejw
Linux Build scan: https://gradle.com/s/fgntbojv4xg3m
Workflow run https://github.com/Flank/flank/actions/runs/852918328

@Sloox
Copy link
Contributor Author

Sloox commented May 18, 2021

@pawelpasterz not sure if anything changed. But its all passing. Had issues on my fork but they dissapeared.
Maybe it needs to be merged before changes are sseen?
WDYT?

@pawelpasterz
Copy link
Contributor

@pawelpasterz not sure if anything changed. But its all passing. Had issues on my fork but they dissapeared.
Maybe it needs to be merged before changes are sseen?
WDYT?

Yeah, changes in workflow are applied once merged to master. Let's give it a try.

One question, there are two ubuntu versions used latest and 20.04, shouldn't we use one of them?

@piotradamczyk5
Copy link
Contributor

piotradamczyk5 commented May 18, 2021

@pawelpasterz not sure if anything changed. But its all passing. Had issues on my fork but they dissapeared.
Maybe it needs to be merged before changes are sseen?
WDYT?

Yeah, changes in workflow are applied once merged to master. Let's give it a try.

One question, there are two ubuntu versions used latest and 20.04, shouldn't we use one of them?

ubuntu-latest is ubuntu-20.04 so for now there is no difference 😄 lets stick to ubuntu-latest

The distribution must be set explicitly as Ubuntu-20.04

@Sloox Sloox enabled auto-merge (squash) May 18, 2021 13:28
@Sloox Sloox merged commit 569df1c into master May 18, 2021
@Sloox Sloox deleted the 1928-ubuntu branch May 18, 2021 13:37
@github-actions github-actions bot locked and limited conversation to collaborators May 18, 2021
Copy link
Contributor Author

@Sloox Sloox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing

@Sloox
Copy link
Contributor Author

Sloox commented May 21, 2021

@flank-it

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ubuntu CI on latest revision is not working
4 participants