Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Enable dump shards IT #1981

Merged
merged 1 commit into from
May 31, 2021
Merged

fix: Enable dump shards IT #1981

merged 1 commit into from
May 31, 2021

Conversation

Sloox
Copy link
Contributor

@Sloox Sloox commented May 31, 2021 •
edited
Loading

Fixes #

Test Plan

How do we know the code works?
We test it.

Checklist

  • Integration tests updated

@Sloox Sloox self-assigned this May 31, 2021
@Sloox
Copy link
Contributor Author

Sloox commented May 31, 2021

@flank-it

@github-actions
Copy link
Contributor

github-actions bot commented May 31, 2021 •
edited
Loading

Integration tests succeed for all OSes ✅
Windows Build scan:
MacOS Build scan: https://gradle.com/s/cxshwawkbciwu
Linux Build scan: https://gradle.com/s/hzchsdz6cb7nc
Workflow run https://github.com/Flank/flank/actions/runs/892043081

@github-actions
Copy link
Contributor

github-actions bot commented May 31, 2021 •
edited
Loading

Timestamp: 2021-05-31 10:50:19
Buildscan url for ubuntu-workflow run 892634461
https://gradle.com/s/kgcqjdnfr2jji

@Sloox Sloox marked this pull request as ready for review May 31, 2021 08:11
@mergify mergify bot merged commit f703b77 into master May 31, 2021
@mergify mergify bot deleted the 1785-dump-shards branch May 31, 2021 11:51
@github-actions github-actions bot locked and limited conversation to collaborators May 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@adamfilipow92 adamfilipow92 adamfilipow92 approved these changes

@zuziaka zuziaka zuziaka approved these changes

@pawelpasterz pawelpasterz Awaiting requested review from pawelpasterz

@jan-goral jan-goral Awaiting requested review from jan-goral

@piotradamczyk5 piotradamczyk5 Awaiting requested review from piotradamczyk5

Assignees

@Sloox Sloox

Labels
Bug Snake 🐍
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Sloox @zuziaka @adamfilipow92