fix: Fix flank freezes when large number of matrices is launched #2026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Timestamp: 2021-06-10 18:37:23 |
|
Tried this fix out and it works great! Thank you for the quick help! |
|
@flank-it |
|
Integration tests succeed for all OSes ✅ |
adamfilipow92
approved these changes
Jun 11, 2021
mergify
bot
deleted the
2021-fix-flank-freezes-with-largre-number-matrices
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2021
Test Plan
It is impossible to test whole flow in sensible and reliable way. It would require mocking lots of methods and since the problem is related with multithreading I think it's not the best idea. What's more, test might be unreliable due to differences in CPU configurations on different machines.
@asadsalman was asked to verify fix, as a proof (thanks!)