Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added new Parameterized Test Option #2035

Merged
merged 4 commits into from
Jun 18, 2021
Merged

Conversation

Sloox
Copy link
Contributor

@Sloox Sloox commented Jun 17, 2021

Part 1 for Fixes of #2023

Test Plan

How do we know the code works?

Its tested. At this point the new param does not influence flank but this PR is to discuss its addition is in the right place and to move forward.
Part 2 will be actual implementation.

Issue wont be connected so its not moved to done when closed.

Again take note that this is a set of new options to give users of flank better control over the use of Parameterized tests.
Apart of the #1720

Checklist

  • Documented
  • Unit tested

@Sloox Sloox added Android Snake 🐍 New Option Used to track PR with new configuration option (useful when updating fladle) labels Jun 17, 2021
@Sloox Sloox self-assigned this Jun 17, 2021
@mergify
Copy link

mergify bot commented Jun 17, 2021

Title does not follow the guidelines of Conventional Commits.
Please adjust title before merge and use one of following prefix:

  • build - Changes that affect the build system or external dependencies (dependencies update)
  • ci - Changes to our CI configuration files and scripts (basically directory .github/workflows)
  • docs - Documentation only changes
  • feat - A new feature
  • fix - A bug fix
  • chore - Changes which does not touch the code (ex. manual update of release notes). It will not generate release notes changes
  • refactor - A code change that contains refactor
  • style - Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test - Adding missing tests or correcting existing tests and also changes for our test app
  • perf - A code change that improves performance (I do not think we will use it)

@Sloox Sloox changed the title Added new option feat: Added new Parameterized Test Option Jun 17, 2021
@Flank Flank deleted a comment from github-actions bot Jun 17, 2021
@Sloox
Copy link
Contributor Author

Sloox commented Jun 17, 2021

@flank-it

@github-actions
Copy link
Contributor

github-actions bot commented Jun 17, 2021

Integration tests succeed for all OSes ✅
Windows Build scan:
MacOS Build scan: https://gradle.com/s/w2wpr6hzaaos6
Linux Build scan: https://gradle.com/s/hvokymvdljtow
Workflow run https://github.com/Flank/flank/actions/runs/946283930

@github-actions
Copy link
Contributor

github-actions bot commented Jun 17, 2021

Timestamp: 2021-06-18 10:08:27
Buildscan url for ubuntu-workflow run 949466475
https://gradle.com/s/6el35wp72sv4i

@bootstraponline bootstraponline force-pushed the #2023-add-new-options branch from 612660d to b883204 Compare June 17, 2021 17:41
@Sloox Sloox enabled auto-merge (squash) June 18, 2021 09:09
@bootstraponline bootstraponline force-pushed the #2023-add-new-options branch from b883204 to 77f0ac6 Compare June 18, 2021 09:50
@pawelpasterz
Copy link
Contributor

LGTM 👍🏻

@bootstraponline bootstraponline force-pushed the #2023-add-new-options branch from 77f0ac6 to 6f75e17 Compare June 18, 2021 10:01
@Sloox Sloox requested a review from zuziaka June 18, 2021 11:19
@Sloox Sloox merged commit ad43895 into master Jun 18, 2021
@Sloox Sloox deleted the #2023-add-new-options branch June 18, 2021 11:41
@github-actions github-actions bot locked and limited conversation to collaborators Jun 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Feature New Option Used to track PR with new configuration option (useful when updating fladle) P1 Snake 🐍 Tiger 🐯
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants