fix: Enhance table builder logic #2043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Timestamp: 2021-06-25 07:36:30 |
jan-goral
reviewed
Jun 24, 2021
pawelpasterz
force-pushed
the
1893-enhance-alignment-feature-in-table-builder
branch
from
de07d2f to
f031c40
Compare
Sloox
approved these changes
Jun 24, 2021
| @@ -145,3 +157,11 @@ private fun DataWithSize.center() = String.format( | |||
| ) | |||
|
|
|||
| inline fun TableColumn.applyColorsUsing(mapper: (String) -> SystemOutColor) = copy(dataColor = data.map(mapper)) | |||
|
|
|||
| // RESOLUTION column needs dedicated alignment logic and data pre-processing | |||
There was a problem hiding this comment.
Is this a todo or something that has been achieved?
There was a problem hiding this comment.
It's not a todo, it's just a short info why we have additional method here
test_runner/src/main/kotlin/ftl/environment/TestEnvironmentInfo.kt
Outdated
Show resolved
Hide resolved
pawelpasterz
force-pushed
the
1893-enhance-alignment-feature-in-table-builder
branch
from
c448769 to
1018578
Compare
jan-goral
reviewed
Jun 24, 2021
| @@ -12,16 +12,19 @@ data class TableColumn( | |||
| val header: String, | |||
| val data: List<String>, | |||
| val dataColor: List<SystemOutColor> = listOf(), | |||
| val columnSize: Int = ((data + header).maxByOrNull { it.length }?.length ?: 0) + DEFAULT_COLUMN_PADDING | |||
| val columnSize: Int = ((data + header).maxByOrNull { it.length }?.length ?: 0) + DEFAULT_COLUMN_PADDING, | |||
| val align: Align | |||
There was a problem hiding this comment.
As @piotradamczyk5 mentioned, Align.LEFT could set as default, also here.
There was a problem hiding this comment.
@jan-gogo @piotradamczyk5
IMO it's clearer to force explicit alignment set up and I do not fully agree with you.
On the other hand I don't have very strong opinion about it and I'm in minority in that case, so sure, I'll change it 👍🏻
piotradamczyk5
approved these changes
Jun 25, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1893
Test Plan
./gradlew flankFullRunflank firebase test android models listOS_VERSION_IDScolumn aligned to the leftRESOLUTIONcolumn centered byxmark