feat: Move Mixpanel metrics to tools:analytics #2086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamfilipow92
commented
Jul 14, 2021
| @@ -28,21 +24,6 @@ object CostReport : IReport { | |||
| totalBillablePhysicalMinutes += it.billableMinutes.physical | |||
| } | |||
|
|
|||
| val virtualCost = calculateVirtualCost(totalBillableVirtualMinutes.toBigDecimal()) | |||
There was a problem hiding this comment.
Removed because currently causing failed tests. We will merge all events into single #2087 so this event is currently redundant
|
Timestamp: 2021-07-14 16:50:10 |
piotradamczyk5
approved these changes
Jul 14, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Test Plan
This is part of #2044. Everything should work as before. Tests should pass.