Add option to prevent uploading results for Smart Flank #537
Conversation
|
|
elihart
force-pushed
the
eli-optional_upload
branch
from
a7ed2cf to
6f1819d
Compare
|
Thanks! That's definitely a feature we want to support. |
|
If you run |
Codecov Report
@@ Coverage Diff @@
## master #537 +/- ##
=========================================
Coverage 79.65% 79.65%
Complexity 563 563
=========================================
Files 77 77
Lines 2109 2109
Branches 276 276
=========================================
Hits 1680 1680
Misses 265 265
Partials 164 164 |
|
Thanks for the tip, fixed! I was going off the contributing doc which says to use |
|
ah, yeah we replaced ktlint with detekt. I'll update the doc |
| ## This can be disabled to prevent new results from overriding previous results. | ||
| ## Default: true | ||
| # smart-flank-upload-enabled: true | ||
|
|
||
| ## Disables sharding. Useful for parameterized tests. | ||
| # disable-sharding: false | ||
|
|
There was a problem hiding this comment.
I think for consistency with disable-sharding, I'd like the flag renamed to:
smart-flank-disable-upload
then in the code we can check args.smartFlankDisableUpload instead of !args.smartFlankUploadEnabled.
The description can be written like this:
Disables smart flank JUnit XML uploading. Useful for preventing timing data from being updated.
I'm happy to make both changes if you'd like.
There was a problem hiding this comment.
sure thing, I'll do it
There was a problem hiding this comment.
Perfect, thanks. After that I'll merge the PR.
elihart
force-pushed
the
eli-optional_upload
branch
from
7cfbc94 to
aa5b368
Compare
|
All cleaned up, I think it should be good to go. Thanks for the quick review! Any idea when you might be able to push a new release with this change? I'd love to get it into our app soon. |
|
Awesome work! The Flank release process is fully automated. The snapshot jar is released after every merged PR. The stable releases are auto uploaded after I tag a version in git. I'll tag a |
|
|
Hi, thanks for this great library! I noticed that https://github.com/TestArmada/flank/blob/master/docs/smart_flank.md mentioned the possible improvement to disable uploading smart flank results, so I implemented it.
I have recently added Flank to our test suite at Airbnb, and I'd love this support to allow us to run a subset of tests on some branches without overwriting the master set of results.