-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Deps.kt the source of truth for dependencies #641
Conversation
CLA Assistant Lite All Contributors have signed the CLA. |
Codecov Report
@@ Coverage Diff @@
## master #641 +/- ##
============================================
- Coverage 76.31% 76.22% -0.09%
Complexity 610 610
============================================
Files 81 81
Lines 2297 2297
Branches 327 327
============================================
- Hits 1753 1751 -2
- Misses 324 326 +2
Partials 220 220 |
Hey @doodla could you change commits message to be more explanatory? Thanks :) |
I have read the CLA Document and I hereby sign the CLA |
It's too much work, imo. The PR title should be sufficient. I usually don't bother with detailed commit messages in repositories where the pull requests are merged by squashing. |
Got it, thanks for answer |
For some more context, my thinking is that Pull requests are atomic commits ( squash merge ) into the If a pull request can be divided into multiple discrete chunks, each chunk can be a separate pull request to decrease the size and make the reviewers' lives easy. |
Versions haven't been modified, so if this builds and passes tests, we should be good to go.