Fix logging level for both root and Bugsnag not being initialized #687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #687 +/- ##
=========================================
Coverage 77.30% 77.30%
Complexity 624 624
=========================================
Files 109 109
Lines 2529 2529
Branches 360 360
=========================================
Hits 1955 1955
Misses 345 345
Partials 229 229 |
jan-goral
approved these changes
Mar 30, 2020
| @@ -39,7 +39,8 @@ class Main : Runnable { | |||
|
|
|||
| @CommandLine.Option( | |||
| names = ["--debug"], | |||
| description = ["Enables debug logging"] | |||
| description = ["Enables debug logging"], | |||
| defaultValue = "false" | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #682
Due to lazy initialization of Kotlin's objects logging level was not set (default was used).
Checklist