Allow runtime test discovery when sharding is disabled by not setting test-targets. This unblocks cucumber testing #822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamfilipow92
changed the title
Codecov Report
@@ Coverage Diff @@
## master #822 +/- ##
============================================
+ Coverage 78.12% 78.30% +0.17%
Complexity 667 667
============================================
Files 149 149
Lines 3004 3014 +10
Branches 437 439 +2
============================================
+ Hits 2347 2360 +13
+ Misses 375 374 -1
+ Partials 282 280 -2 |
release_notes.md
Outdated
| @@ -9,6 +9,7 @@ | |||
| - [#805](https://github.com/Flank/flank/pull/805) Fix overlapping results. ([pawelpasterz](https://github.com/pawelpasterz)) | |||
| - [#812](https://github.com/Flank/flank/issues/812) Convert bitrise macOS workflow to github action. ([piotradamczyk5](https://github.com/piotradamczyk5)) | |||
| - [#799](https://github.com/Flank/flank/pull/799) Refactor Shared object by splitting it into smaller functions. ([piotradamczyk5](https://github.com/piotradamczyk5)) | |||
| - [#822](https://github.com/Flank/flank/pull/822) Prevent set test targets is sharding is disabled and test-targets not set. ([adamfilipow92](https://github.com/adamfilipow92)) | |||
There was a problem hiding this comment.
I'd say it like this:
Allow runtime test discovery when sharding is disabled by not setting test-targets. This unblocks cucumber testing
bootstraponline
previously approved these changes
May 28, 2020
adamfilipow92
force-pushed
the
#815-prevent-set-test-targets-when-disable-sharding-set-to-true
branch
from
30b0ebe to
483a5f1
Compare
In CreateAndroidInstrumentationTest
bootstraponline
approved these changes
May 30, 2020
adamfilipow92
changed the title
adamfilipow92
deleted the
#815-prevent-set-test-targets-when-disable-sharding-set-to-true
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #815
Checklist