Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#885 Print provided software #904

Merged
merged 3 commits into from
Jul 21, 2020
Merged

Conversation

piotradamczyk5
Copy link
Contributor

@piotradamczyk5 piotradamczyk5 commented Jul 20, 2020

Fixes #885

Test Plan

How do we know the code works?

Use on of a new CLI option to test this PR:

  • flank firebase test provided-software list or flank provided-software list - print provided software version
Sample output:

┌──────────────────────┐
│ ORCHESTRATOR VERSION │
├──────────────────────┤
│        1.0.2         │
└──────────────────────┘


More listing options of the test environment will be added in the next tasks

Checklist

  • printing provided software list
  • Documented
  • Unit tested
  • release_notes.md updated

release_notes.md Outdated
@@ -5,6 +5,7 @@
- [#894](https://github.com/Flank/flank/pull/894) Added option to print Android available versions to test against. ([piotradamczyk5](https://github.com/piotradamczyk5))
- [#897](https://github.com/Flank/flank/pull/897) Added option to print iOS available versions to test against. ([piotradamczyk5](https://github.com/piotradamczyk5))
- [#901](https://github.com/Flank/flank/pull/901) Added option to print Android and iOS available test-environment. ([piotradamczyk5](https://github.com/piotradamczyk5))
- [#901](https://github.com/Flank/flank/pull/901) Added option to print provided software. ([piotradamczyk5](https://github.com/piotradamczyk5))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably small mistake its #904 pull

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed 👍

Copy link
Contributor

@adamfilipow92 adamfilipow92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@piotradamczyk5 piotradamczyk5 merged commit bc0e1cc into master Jul 21, 2020
@piotradamczyk5 piotradamczyk5 deleted the #885-print-provided-software branch July 21, 2020 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add printing providing software to show orchestrator versions
2 participants