fix: exclusion of @Suppress test #990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotradamczyk5
requested review from
adamfilipow92,
bootstraponline,
jan-goral,
pawelpasterz and
Sloox
pawelpasterz
previously approved these changes
Aug 13, 2020
added 2 commits
August 13, 2020 13:12
piotradamczyk5
dismissed stale reviews from pawelpasterz and kozaxinan
via
a530f7a
piotradamczyk5
force-pushed
the
#984-include-suppress-tests
branch
from
6d1d076 to
a530f7a
Compare
jan-goral
approved these changes
Aug 13, 2020
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #984
Test Plan
Tests marked with annotation
androidx.test.filters.Suppressorandroid.support.test.filters.Suppressare treated likeorg.junit.Ignore.If you run tests with this annotation you could see that these tests are ignored.
You could also run with
--dump-shardsoption to check if the required test is included injunit-ignoredsectionChecklist