Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Planes are destroying bedrocks #1210

Closed
ken1882 opened this issue May 6, 2020 · 0 comments · Fixed by #1218
Closed

Planes are destroying bedrocks #1210

ken1882 opened this issue May 6, 2020 · 0 comments · Fixed by #1218
Labels
bug Something isn't working

Comments

@ken1882
Copy link
Contributor

ken1882 commented May 6, 2020

Describe the bug

When plane wings collided with blocks the block will break also damaging the part, including bedrock

To Reproduce
Steps to reproduce the behaviour:

  1. Using /fill to generate a bedrock plain
  2. Get a plane and put it on bedrock
  3. Wreck your plane
  4. Destroy bedrock and fall out of the world

Expected behaviour

Indestructible blocks should not be destroyed

Screenshots

Versions (please complete the following information)

  • Forge: 1.12.2
  • Flan's Mod: v5.6-beta7

Additional context

It seems already on TODO but I'll post it anyway. When the block hardness is -1, the damage factor should changed to much higher value like 100 and don't destroy the block
EntityDriveable.java line 1334

// Attack the part
if(!attackPart(p.part, DamageSource.IN_WALL, 
	blockHardness * blockHardness * (float)speed) && TeamsManager.driveablesBreakBlocks) {

	// And if it didn't die from the attack, break the block
	// TODO: [1.12] Heck
	// playAuxSFXAtEntity(null, 2001, pos, Block.getStateId(state));
					
	if(!world.isRemote){
		WorldServer worldServer = (WorldServer)world;
		destroyBlock(worldServer, pos, getDriver(), true);
	}
}
@ken1882 ken1882 added the bug Something isn't working label May 6, 2020
ken1882 added a commit to ken1882/FlansMod that referenced this issue May 8, 2020
ken1882 added a commit to ken1882/FlansMod that referenced this issue May 8, 2020
ken1882 added a commit to ken1882/FlansMod that referenced this issue May 10, 2020
@ken1882 ken1882 mentioned this issue May 10, 2020
ChrisLane pushed a commit that referenced this issue May 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
1 participant