Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1088

Merged
merged 7 commits into from
Jul 30, 2019
Merged

Fixes #1088

merged 7 commits into from
Jul 30, 2019

Conversation

Liruxo
Copy link
Contributor

@Liruxo Liruxo commented Jul 26, 2019

Here are the fixes for for #1083 and #1084 as well as a replacement of an non ascii charater to prevent it from causing more issues

Copy link
Member

@ChrisLane ChrisLane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Server still crashes when shooting an enemy:
Crash log

Confirmed that gun sounds are fixed.

@ChrisLane ChrisLane mentioned this pull request Jul 29, 2019
@ChrisLane ChrisLane merged commit 419b837 into FlansMods:1.12.2 Jul 30, 2019
@ChrisLane
Copy link
Member

I did notice that there are a couple of other issues. Firstly, hit markers don't work when shooting a player in normal survival (tested on a dedicated server with ./gradlew runServer and two clients with ./gradlew runClient. Second, flan's mod death messages are shown twice.

I'll open new issues for these.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants