Remove title from <iframe /> container

[cauli]

Overview

On Firefox, a tooltip appears when hovering clickable elements inside the iframe with the "title" attribute of the iframe. Hovering over the an action button "Submit", for example, would show "Embedded Portal Content", which was distracting. Removing the title should solve the issue.

On Chrome, this tooltip was visible only when hovering the edges of the iframe, not the content itself.

Screenshot of the issue

Please explain how to summarize this PR for the Changelog:

A fix that removes the title tooltip of Flatfile's iframe, that was causing a tooltip "Embedded Portal Contents" to appear in some browsers (affected mainly Firefox)

Tell code reviewer how and what to test:

• Open Firefox with the current version of the libs, and hover clickable elements until the tooltip "Embedded Portal Contents" appears
• Open Firefox with this version of the libs, and the tooltip should be gone

Workaround

We are currently using a useFlatfileIframeTitleRemover React hook, that observes DOM changes for the iframe being injected, and remove it's title attribute if necessary.

import { useEffect } from 'react'

/**
 * The <iframe class="flatfile_iFrameContainer" /> injected by Flatfile has a
 * title attribute that causes a tooltip to appear when hovering some elements.
 *
 * @note This is particularly noticeable in Firefox (clickables will show a tooltip)
 * On Chrome, it appears when hovering the borders of the iframe.
 *
 * @see https://github.com/FlatFilers/flatfile-core-libraries/blob/6773e36c90fdfedc3da50aeaafa3e85f1c4dbabd/packages/react/src/components/EmbeddedIFrameWrapper.tsx#L117 for original implementation. It might change.
 */
export function useFlatfileIframeTitleRemover(
  selector = '.flatfile_iFrameContainer',
  targetTitle = 'Embedded Portal Content',
) {
  // Creates a mutation observer that queries for Flatfile's iframe
  // and removes its title, if it matches the title we expect
  useEffect(() => {
    if (typeof MutationObserver === 'undefined') {
      // ignore this hook if the browser doesn't support MutationObserver
      return
    }

    const removeIframeTitle = () => {
      const iframe = document.querySelector(selector) as HTMLIFrameElement

      if (
        iframe &&
        iframe.tagName === 'IFRAME' &&
        iframe.title === targetTitle
      ) {
        iframe.removeAttribute('title')
      }
    }

    removeIframeTitle()

    const observer = new MutationObserver((mutations) => {
      mutations.forEach((mutation) => {
        if (mutation.type === 'childList') {
          removeIframeTitle()
        }
      })
    })

    observer.observe(document.body, {
      childList: true,
      subtree: true,
    })

    return () => observer.disconnect()
  }, [selector, targetTitle])
}

[coderabbitai]

Walkthrough

The pull request involves removing the title attribute from <iframe> elements across multiple components in React and Vue packages. This change affects components like EmbeddedIFrameWrapper, InitSpace, LegacySpace, and SpaceC, systematically eliminating the "Embedded Portal Content" title from iframes. The modification appears to be a deliberate, consistent removal of iframe titles across different framework-specific implementations.

Changes

File	Change Summary
packages/react/src/components/EmbeddedIFrameWrapper.tsx	Removed title attribute from <iframe>
packages/react/src/components/legacy/InitSpace.tsx	Removed title attribute from <iframe>
packages/react/src/components/legacy/LegacySpace.tsx	Removed title attribute from <iframe> in SpaceContents
packages/vue/src/components/SpaceC.vue	Removed title attribute from <iframe>

Potential Accessibility Impact

While not part of the original instructions, it's worth noting that removing the title attribute from iframes may negatively impact accessibility, as screen readers and assistive technologies rely on these titles to provide context about embedded content. The systematic removal across multiple components suggests this might be an intentional design decision, but it could potentially reduce the user experience for users dependent on assistive technologies.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6773e36 and 354c8d0.

📒 Files selected for processing (4)

• packages/react/src/components/EmbeddedIFrameWrapper.tsx (0 hunks)
• packages/react/src/components/legacy/InitSpace.tsx (0 hunks)
• packages/react/src/components/legacy/LegacySpace.tsx (0 hunks)
• packages/vue/src/components/SpaceC.vue (0 hunks)

💤 Files with no reviewable changes (4)

• packages/react/src/components/legacy/LegacySpace.tsx
• packages/react/src/components/EmbeddedIFrameWrapper.tsx
• packages/vue/src/components/SpaceC.vue
• packages/react/src/components/legacy/InitSpace.tsx

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.