Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem creating new behaviours #4

Closed
capox95 opened this issue Apr 2, 2017 · 16 comments
Closed

Problem creating new behaviours #4

capox95 opened this issue Apr 2, 2017 · 16 comments
Assignees

Comments

@capox95
Copy link

capox95 commented Apr 2, 2017

Hi, I have some problems when I try to create new behaviors.
Here the error message:
link

If I use the default behaviors available I have no problem at all!
(but if I load them, change the name and then I try to save, here we have the error!)

Obviously I am not able to see my new behavior on the "select behaviors" column!

Behaviors Packages: "flexbe_behaviors"
State Packages: "flexbe_states"

I think that could be a problem with my configuration or maybe with the app because with the Chrome_App everything was fine.

Thanks,
Alessio

@pschillinger pschillinger self-assigned this Apr 4, 2017
@dcconner
Copy link
Member

dcconner commented Apr 6, 2017

We are seeing this as well. As a work around if we "touch new_behavior_sm.py" and create an empty file first, then it seems to work OK afterwards.

@dcconner
Copy link
Member

dcconner commented Apr 6, 2017

Sometimes we don't get any output to the terminal log screen, but sometimes we get "Code Generation completed" and "Manifest generation completed", but then error
"file new_behavior_sm.py not found in specified folder" (where new_behavior was our test name) and no files are actually created (confirmed in master and develop branches)

@pschillinger
Copy link
Member

There was a bug preventing to create a new behavior if the onboard engine was running and the app was connected to it.

David, the error which shows no terminal output has a different reason, but should be fixed now as well.

Please let me know if there is still another problem with creating behaviors I am not aware of.

@TGiles
Copy link

TGiles commented Apr 10, 2017

We tested with latest change, and it saves behavior but when we try to run

[ERROR] [WallTime: 1491867753.906567] bad callback: <bound method BehaviorLauncher._callback of <flexbe_widget.behavior_launcher.BehaviorLauncher object at 0x7f9d2345c990>>
Traceback (most recent call last):
  File "/opt/ros/kinetic/lib/python2.7/dist-packages/rospy/topics.py", line 720, in _invoke_callback
    cb(msg)
  File "/home/cpsc495_team1/Desktop/cpsc495/src/flexbe_behavior_engine/flexbe_widget/src/flexbe_widget/behavior_launcher.py", line 38, in _callback
    be_id, behavior = self._behavior_lib.find_behavior(msg.behavior_name)
TypeError: 'NoneType' object is not iterable

If we exit FlexBE then restart, then the new behavior is waiting on us and works.

@pschillinger
Copy link
Member

Ok, makes sense. The behavior library of the launcher only updates once when being started. I will fix this.

pschillinger added a commit to team-vigir/flexbe_behavior_engine that referenced this issue Apr 18, 2017
@pschillinger
Copy link
Member

Updating the flexbe_behavior_engine repo should fix the above error, at least it works for me now.

@matteopantano
Copy link

matteopantano commented Apr 20, 2017

I have tried to update the two packages, switching to feature/flexbe_app in flexbe_behavior_engine and switching to develop in flexbe_app but when I try to save my behavior nothing happens, terminal does not give me any response. Furthermore if I try to push the Start Execution in Runtime Control nothing starts.
Am I missing something?

FIXED: It was not clear that I should have had to disconnect the ROS master to create a new behavior

@pschillinger
Copy link
Member

It should not be necessary to disconnect ROS. As I wrote above:

There was a bug preventing to create a new behavior if the onboard engine was running and the app was connected to it.

Consequently, it was a workaround to disconnect ROS. But this should not be required anymore. Since I am not able to reproduce what you describe, can you give me a few more details regarding your workspace setup and the behavior which fails to save such that I can try to reproduce?

@matteopantano
Copy link

Well behavior is quite simple, I just have one state regarding opening and closing of the gripper (I am using this one in another behavior and it works). When i save I have no errors however if I try to push the button start execution nothing happens. As I said before if I disconnect the master the behavior saves and I can access to it the next time I will open the app, on the other hand if I save it w/out disconnecting i will not find it in the list.

The behaviors I am using are in folder youbot_behaviors antecedently downloaded from the github repository youbot_behaviors.

And here some pic of the setup.

@pschillinger
Copy link
Member

Thank you! One thing that looks surprising to me is that on the flexbe_conf screenshot it looks like youbot_flexbe_states (which contains the gripper state) is not detected as state package. The youbot_behaviors repo has not been converted to the new flexbe_app format, did you do this yourself? Maybe something related to this is causing the issue.

I tested it and pushed a new feature/flexbe_app branch on youbot_behaviors. Can you try again on this branch and the current version of flexbe_behavior_engine and flexbe_app? In the App, the version indicator (top right corner) should be green.

@matteopantano
Copy link

Except from initial errors now seems to work, probably one thing missing is the possibility to delete a behaviour.

@astumpf
Copy link

astumpf commented Jan 26, 2018

Hey,
we are using FlexBE App in our lecture. Many students (myself included) have the described issue above. It works usually, but sometimes FlexBE App refuses to save. There is neither an error message nor any strange visible behavior. The app pretends to have saved but indeed didn't.
Any guess?

@pschillinger
Copy link
Member

Which of the issues discussed above?

It works usually, but sometimes FlexBE App refuses to save.

Have you observed any difference between the cases where it worked and where not? For example, if a ROS connection is active, the kind of changes before saving, etc?

It is hard to make a guess without any context...

@astumpf
Copy link

astumpf commented Jan 28, 2018

In the meantime we figured out the issue: You have to set the "Package" at least once, although it does already have a selection. It seems as the app didn't initialize the internal value from the drop down menu initially.

@pschillinger
Copy link
Member

@astumpf I started to look into this, but cannot reproduce it. Can you confirm you were using a version which included the commit 68d8257?

@hbaqueiro
Copy link

@astumpf I'm facing the same problem. How could you manage to set the Package? My package dropdown menu is empty, so I can't set it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants