Declare missing system dependencies #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asierfernandez
force-pushed
the
declare-missing-dependencies
branch
from
6fccf2f
to
cb23702
Compare
dcconner
approved these changes
May 18, 2023
dcconner
pushed a commit
that referenced
this pull request
May 19, 2023
fmessmer
pushed a commit
to fmessmer/flexbe_app
that referenced
this pull request
Jul 6, 2023
fmessmer
pushed a commit
to fmessmer/flexbe_app
that referenced
this pull request
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are running FlexBE app inside a docker container, and we've noticed that some of system dependencies are not declared on the
package.xml.We've tested on
ros:kinetic,ros:melodicandros:noeticimages, and in all cases same dependencies are left.This issue probably doesn't show up with a desktop environment where the dependencies, specially the ones related with the graphical stuff, are installed with the OS installation.
After installing them within mentioned docker containers, the
flexbe_appruns as expected.