Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove needless registry key #33

Merged
merged 1 commit into from
Sep 12, 2024
Merged

Remove needless registry key #33

merged 1 commit into from
Sep 12, 2024

Conversation

HashidaTKS
Copy link
Contributor

@HashidaTKS HashidaTKS commented Sep 12, 2024

FlexConfirmMail supports Outlook 2016+, so we need add registry keys only for Software\Microsoft\Office\16.0.
Also, Office skips the internal version "13", so there is no Office version corresponding to Software\Microsoft\Office\13.0.
(I didn't find the primary source though...)

https://web.archive.org/web/20090513124655/http://www.computerworld.jp/news/sw/58333.html
https://ja.wikipedia.org/wiki/Microsoft_Office

Test

  • Confirm that the installer works fine
  • Confirm that the registry key HKEY_CURRENT_USER\Software\Microsoft\Office\13.0\Outlook\Resiliency\DoNotDisableAddinList does not exist
  • Confirm that the values of the registry key HKEY_CURRENT_USER\Software\Microsoft\Office\16.0\Outlook\Resiliency\DoNotDisableAddinList contains FlexConfirmMail

FlexConfirmMail supports Outlook 2016+, so we need add a key only for `Software\Microsoft\Office\16.0`.
Also, Office skips the internal version "13", so there is no Office version corresponding to `Software\Microsoft\Office\13.0`.
@HashidaTKS HashidaTKS changed the title Remove needless registry entity Remove needless registry key Sep 12, 2024
@piroor piroor merged commit 978e554 into master Sep 12, 2024
1 check failed
@piroor piroor deleted the remove-needless-reg-key branch September 12, 2024 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants