Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#13]fix Readme examples #14

Merged
merged 2 commits into from
Jun 20, 2017
Merged

[#13]fix Readme examples #14

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
45b79d1
fixed path for running examples
Jun 15, 2017
524bba4
update readme
Jun 20, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions flink-jpmml-examples/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,11 @@ assembly

3) Run the examples. If you want full predictions:
```
./path/to/bin/flink run -c io.radicalbit.examples.EvaluateKmeans --model path/to/pmml/model.pmml --output /path/to/output
./path/to/bin/flink run -c io.radicalbit.examples.EvaluateKmeans path/to/flink-jpmml/flink-jpmml-examples/target/scala-2.11/flink-jpmml-examples-assembly-0.6.0-SNAPSHOT.jar --model path/to/pmml/model.pmml --output /path/to/output
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think </path/to/project/root>/flink-jpmml-examples/target/scala-2.11/flink-jpmml-examples-assembly-0.6.0-SNAPSHOT.jar is better in both cases. I believe also scala-2.11 is correct only if users assembly the project with scala 2.11

```
Either you can employ the _quick_ predictor:
```
./path/to/bin/flink run -c io.radicalbit.examples.QuickEvaluateKmeans --model path/to/pmml/model.pmml --output /path/to/output
./path/to/bin/flink run -c io.radicalbit.examples.QuickEvaluateKmeans path/to/flink-jpmml/flink-jpmml-examples/target/scala-2.11/flink-jpmml-examples-assembly-0.6.0-SNAPSHOT.jar --model path/to/pmml/model.pmml --output /path/to/output
```


Expand Down