Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to react v15+ #159

Merged
merged 6 commits into from
Mar 27, 2017
Merged

Upgrade to react v15+ #159

merged 6 commits into from
Mar 27, 2017

Conversation

pinqy520
Copy link
Contributor

@pinqy520 pinqy520 commented Jan 20, 2017 •
edited
Loading

  • update dependencies
  • add yarn.lock to .gitignore
  • add source map for webpack dev
  • works in react v15+

@reimertz
Copy link

Wow, great job @pinqy520

@pinqy520
Copy link
Contributor Author

....there are some error when the ListView scrolls. I will fix it tomorrow. Don't merge...

@pinqy520
Copy link
Contributor Author

pinqy520 commented Jan 21, 2017 •
edited
Loading

react-canvas

Done~!

This was referenced Jan 21, 2017
Open
Open
Open
@tconroy
Copy link

tconroy commented Feb 4, 2017

this looks great.. Any plans to merge this in?

@pinqy520
Copy link
Contributor Author

pinqy520 commented Feb 6, 2017

ping? @tuxracer

@tuxracer
Copy link
Contributor

tuxracer commented Feb 6, 2017

@pinqy520 awesome work!! I'm not with Flipboard anymore but @tleewu or @hiirene may be able to help with this

@pinqy520
Copy link
Contributor Author

pinqy520 commented Feb 7, 2017

Thanks~! @tuxracer

@athrunsun
Copy link

Guys, are we still waiting for something or someone to merge this?

@tconroy
Copy link

tconroy commented Mar 27, 2017

@athrunsun looking at the commit log it seems @tleewu tried bumping up to 15 back in September but reverted. Why not just merge this PR which seems to be working? :)

@hiirene hiirene merged commit 19319f1 into Flipboard:master Mar 27, 2017
@tconroy
Copy link

tconroy commented Mar 27, 2017

Thank you @hiirene! 🍻

@hiirene
Copy link
Contributor

hiirene commented Mar 27, 2017

Thank @pinqy520 actually :-) and @tuxracer, FYI @tuxracer has updated the package to include this fix.

esiegel pushed a commit to esiegel/react-canvas that referenced this pull request Jun 30, 2018
@hiirene
Merge pull request Flipboard#159 from pinqy520/master
826fb91 
Upgrade to react v15+
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@pinqy520 @reimertz @tconroy @tuxracer @athrunsun @hiirene