Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[evaluator/assign] Fix assign if assigned to nested element #129

Merged
merged 5 commits into from
Oct 30, 2022

Conversation

Flipez
Copy link
Owner

@Flipez Flipez commented Oct 25, 2022

This fixes #115

Signed-off-by: Flipez code@brauser.io

Signed-off-by: Flipez <code@brauser.io>
@vercel
Copy link

vercel bot commented Oct 25, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
rocket-lang ✅ Ready (Inspect) Visit Preview Oct 30, 2022 at 11:45AM (UTC)
rocket-lang-play ✅ Ready (Inspect) Visit Preview Oct 30, 2022 at 11:45AM (UTC)

@codecov
Copy link

codecov bot commented Oct 25, 2022

Codecov Report

Merging #129 (72168f5) into main (7f15823) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #129   +/-   ##
=======================================
  Coverage   86.56%   86.56%           
=======================================
  Files         102      102           
  Lines        3453     3453           
=======================================
  Hits         2989     2989           
  Misses        396      396           
  Partials       68       68           
Impacted Files Coverage Δ
evaluator/assign.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Flipez <code@brauser.io>
Signed-off-by: Flipez <code@brauser.io>
Signed-off-by: Flipez <code@brauser.io>
Signed-off-by: Flipez <code@brauser.io>
@Flipez Flipez changed the title try [evaluator/assign] Fix assign if assigned to nested element Oct 30, 2022
@Flipez Flipez marked this pull request as ready for review October 30, 2022 11:47
@Flipez Flipez added the bug Something isn't working label Oct 30, 2022
@Flipez Flipez merged commit 2e09e9c into main Oct 30, 2022
@Flipez Flipez deleted the fix-nested-index-assign branch October 30, 2022 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2D array access should work within one index operation
1 participant