Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[errorhandling] Fix line position, add file:line:pos to multiple error messages #173

Merged
merged 4 commits into from
Dec 18, 2022

Conversation

Flipez
Copy link
Owner

@Flipez Flipez commented Dec 18, 2022

Signed-off-by: Flipez code@brauser.io

Signed-off-by: Flipez <code@brauser.io>
@vercel
Copy link

vercel bot commented Dec 18, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
rocket-lang ✅ Ready (Inspect) Visit Preview Dec 18, 2022 at 0:27AM (UTC)
rocket-lang-play ✅ Ready (Inspect) Visit Preview Dec 18, 2022 at 0:27AM (UTC)

@codecov
Copy link

codecov bot commented Dec 18, 2022

Codecov Report

Merging #173 (a0c9f55) into main (c04d6e0) will decrease coverage by 0.02%.
The diff coverage is 78.94%.

@@            Coverage Diff             @@
##             main     #173      +/-   ##
==========================================
- Coverage   87.26%   87.24%   -0.03%     
==========================================
  Files         106      106              
  Lines        3629     3621       -8     
==========================================
- Hits         3167     3159       -8     
  Misses        396      396              
  Partials       66       66              
Impacted Files Coverage Δ
ast/object_call.go 87.50% <ø> (ø)
evaluator/foreach.go 82.35% <0.00%> (ø)
parser/parser.go 100.00% <ø> (ø)
repl/repl.go 0.00% <0.00%> (ø)
token/token.go 88.00% <ø> (ø)
main.go 25.00% <50.00%> (ø)
evaluator/identifier.go 100.00% <100.00%> (ø)
evaluator/import.go 100.00% <100.00%> (ø)
evaluator/module.go 87.50% <100.00%> (ø)
evaluator/object_call.go 100.00% <100.00%> (ø)
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Flipez <code@brauser.io>
@Flipez Flipez changed the title Fix line position and add file to error message [errorhandling] Fix line position, add file:line:pos to multiple error messages Dec 18, 2022
@Flipez Flipez changed the title [errorhandling] Fix line position, add file:line:pos to multiple error messages [errorhandling] Fix line position, add file:line:pos to multiple error messages Dec 18, 2022
@Flipez Flipez added bug Something isn't working enhancement New feature or request labels Dec 18, 2022
@Flipez Flipez marked this pull request as ready for review December 18, 2022 12:30
@Flipez Flipez merged commit 4ce7753 into main Dec 18, 2022
@Flipez Flipez deleted the improve-error-message branch December 18, 2022 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant