FDPIN-3560: Job and org analysis support to Dr Elephant #4
Conversation
| @@ -0,0 +1,69 @@ | |||
| package com.linkedin.drelephant.analysis; | |||
|
|
|||
| public class HeuristicDetails { | |||
There was a problem hiding this comment.
Why are setters needed. Lets make it immutable if it can be done.
There was a problem hiding this comment.
Also lets use lombok for the boiler plate?
| @@ -73,6 +75,8 @@ private void loadInfo(String appId, Properties properties) { | |||
|
|
|||
| workflowDepth = 0; // TODO: Add sub-workflow support | |||
| jobName = properties.getProperty(AZKABAN_JOB_NAME); | |||
| organization = properties.getProperty("job.billing.org"); | |||
There was a problem hiding this comment.
Please take these out in constants section.
There was a problem hiding this comment.
Also does dr elephant have an abstract scheduler? If yes then org, namespace interpretation and logic can probably go there. Also I dont see a need to override them in the concrete impls.
| * | ||
| * @return the org name | ||
| */ | ||
| public String getOrganization(); |
There was a problem hiding this comment.
Can this be changed to an abstract class with final implementations for og and sub org so that its available for all schedulers.
|
|
||
| import com.google.gson.*; | ||
| import static java.lang.StrictMath.max; | ||
| import static java.lang.StrictMath.min; | ||
|
|
||
|
|
||
| public class Application extends Controller { |
There was a problem hiding this comment.
The methods in the class are very huge. Either modularize or add good java docs.
FDG-3059 | Fix to enable Tez jobs processing in dr-elephant
Bumped version to 2.2.7
Bumped version to 2.2.10
FDG-3134 | Fixed performance and too many open connections issue
Bumped up the version
FDG-3906: support to search job with PID and EID
FDG-3906: Pulling dependencies from Fk Repository
No description provided.