Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gha tasks #221

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

gha tasks #221

wants to merge 4 commits into from

Conversation

eric-laurello
Copy link
Collaborator

No description provided.

eric-laurello
eric-laurello commented Nov 8, 2023
View reviewed changes
models/deploy/core/_live.sql
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ShahNewazKhan I believe you added these to the flow repo. We're now deploying them from directly from the lq repo using something like :
dbt run -s livequery_models.deploy.core --vars '{UPDATE_UDFS_AND_SPS: true}' -t prod

Will I break anything in flow if I delete these deployment models?

cc @forgxyz

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will break the flow lq workflow as some of the NFL AD / NBA TS metadata models use flow lq for ingestion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShahNewazKhan ShahNewazKhan ShahNewazKhan left review comments

@forgxyz forgxyz forgxyz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eric-laurello @ShahNewazKhan @forgxyz