First iteration for the new plugin system #211
Conversation
FlxG.signals is already working. Right now it only has a single signal (reset), dispatched when FlxG.resetGame() is called.
The TimeManager plugin is now based on the new plugin architecture. It uses signals to monitor state switches. The signal "beforeStateSwitch" was added to FlxG.signals. It is dispatched when the current state is about to be destroyed and the new state is about to be assigned as the current state.
The "postDraw" signal is dispatched after the current state has been drawn. The "preUpdate" signal is dispatched before Flixel updates the current state (and its children). Those are the signals plugins should subscribe to in order to draw on the screen or update itself along with Flixel. DebugPathDisplay and TimerManager have been refactored to rely on those signals.
Plugins were required to extend FlxBasic, but that makes not much sense since plugins were never added to the state display list. I've created FlxPlugin, a simple interface that makes more sense to me. Right now the only required method plugins must implement is destroy(), which is not being invoked, by the way.
I just moved all replay code from one place to another. It compiles, but it's not working. The VCR code was slightly modified, but it remains in place.
The code is a mess with hacks everywhere, but I was able to save a replay session, load and play it. Best of all, it WORKED! HA! The VRC UI is not updating, I didn't test pausing/resuming/stopping the replay.
|
Is this pull request still in progress, or are you still wanting to add any more commits to it before it is merged? Sorry I haven't had a chance to have a good luck at your code yet or test it out for myself, but since you have tested it in the Sandbox, when you feel it is at a stable state and you are finished with it, you are welcome to merge it. |
|
I've started working on the record functionality, which I was planning to do after the pull request got merged. I think I will just add the comments/docs I left behind and merge it. The record functionality will be broken, but at least the new plugin architecture will be ready to be used by everyone on |
I've renamed FlxG_ignoreInput to FlxG.ignoreInput. There was a commented code in FlxGame regarding the VCR replay. It was removed for now and will be incorporate into the replay plugin soon.
|
I'm done adding commits to this 😄 The new plugin architecture is stable and ready to be used. I've tested it and it's good to go (excluding |
First iteration for the new plugin system. The replay functionality was moved to the new plugin architecture too, but it's not working.
This is pull request 1 of 3 regarding the new plugin system. Here's what I've done so far:
FlxSignalandFlxG.signals. There are a couple signals already working (e.g.preUpdate);TimeManagerandDebugPathDisplayto use the new plugin architecture;FlxPlugin) to define the structure of any plugin;What is missing (next tasks):
Please give feedback about the code and the architecture. I've tried to mimic HaxeFlixel API/names/packages when possible. After this pull request gets merged, I will start working on the record plugin.